search

bishop335 / subtext

Automatically exported from code.google.com/p/subtext
0 stars 0 forks source link

Code review request #247

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Phil, could you please have a look at r4094 and tell me why the trick was there 
and if it's fine to remove it?
Thx

PS: don't pay attention to the Branch Path field below, just added to please 
the issue tracker :)

Original issue reported on code.google.com by simone.chiaretta on 30 Jul 2010 at 10:59

GoogleCodeExporter commented 9 years ago 
There was a bug in routing encoding with "#" chars. I don't believe it's been 
fixed so we may still need that hack.

Original comment by haac...@gmail.com on 30 Jul 2010 at 3:51

GoogleCodeExporter commented 9 years ago 
The test was failing with the hack in place: it was encoding also the brackets 
and the column. Without the hack it encodes the pound sign correctly: I guess 
it's fine ghat way then

Original comment by simone.chiaretta on 30 Jul 2010 at 3:57