search

bishop335 / subtext

Automatically exported from code.google.com/p/subtext
0 stars 0 forks source link

Subtext.Framework.Data.Transformer.BuildMonthLinks Does Not Set the Link Category #257

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
The Subtext.Web.UI.Controls.SingleColumn control uses a method 
"GetArchiveCategories" to retrieve the various categories to display in the 
sidebar.

GetArchiveCategories uses Subtext.Web.UI.UIData.ArchiveMonth to get the 
complete list of months built into a big link collection for that control. The 
UIData.ArchiveMonth method calls Transformer.BuildMonthLinks to accomplish its 
goal.

Unfortunately, Transformer.BuildMonthLinks does not set the link collection 
category type to CategoryType.ArchiveMonthCollection, which means it comes back 
as a default/arbitrary "LinkCollection" category.

The downstream effect of this is that if custom controls wish to do filtering 
or manipulation of the (generally rather large) list of months, they are unable 
to determine based on the collection's link category which of the sets of links 
correspond to the huge list of months. The best they can do is compare the 
collection titles.

The fix is, of course, a one-liner: Set Transformer.BuildMonthLinks to modify 
the returned collection's category to CategoryType.ArchiveMonthCollection.

Original issue reported on code.google.com by travis.illig on 18 Aug 2010 at 4:25