Contact Form Doesn't Alert Admin that Email Wasn't Sent

[GoogleCodeExporter]

Subtext 2.5.2.0

What steps will reproduce the problem?
1. Log into your blog.
2. Visit the contact form and send an email.
3. Note the "Success" message but no email was sent.

The success message is misleading, especially if the admin user is trying to 
use the contact form to troubleshoot email sending issues. The message should 
be adjusted to say something like "Email was not sent because you are currently 
logged in as an administrator." Either that, or the check for admin should be 
removed entirely. Does it really matter if an admin wants to send themselves 
email?

Original issue reported on code.google.com by travis.illig on 3 Nov 2010 at 7:32

[GoogleCodeExporter]

Just to make it clearer: when you are logged in as Administrator, the email is 
not sent, but "success" is displayed as message.
Maybe it is better to remove this check so that admins can test if the mail 
server is correctly configured.

Original comment by simone.chiaretta on 30 Nov 2010 at 8:48

• Added labels: Priority-Low
• Removed labels: Priority-Medium

[GoogleCodeExporter]

Sure, as long as we limit it to the Contact form. I don't want to be emailed 
when I comment on my own blog post. But I don't see why I'd regularly contact 
myself, so it's fine to send email from the contact form. :)

Original comment by haac...@gmail.com on 30 Nov 2010 at 4:42

[GoogleCodeExporter]

Yep, just the contact form :)

Original comment by simone.chiaretta on 30 Nov 2010 at 4:49

[GoogleCodeExporter]

That logic belongs in the EmailService which is used in multiple places. Was 
easier just to provide a better message in this case.

Fixed in r4192

Original comment by haac...@gmail.com on 16 May 2011 at 3:59

• Changed state: Fixed
• Added labels: Milestone-Release2.6

[GoogleCodeExporter]

Original comment by Simon.JPhilp on 29 May 2011 at 4:18

• Changed state: Verified