Broken imports in test/test_audio.py

[ajwells256]

Following the instructions for initial testing found on the blog and in the README

python sopare.py -u
python test/test_audio.py 

python throws an error about import sopare.log, saying sopare.log coudn't be found. The path is modified to include "../sopare" via sys.path.append('../sopare') which means import log ought to work (since log is inside the sopare folder), but I found that it didn't (I'm befuddled). Using sys.path.append('../') in combination with import sopare.log also failed; equally befuddling.

In the interest of making as few changes as possible, I added the main directory to the system path using sys.path.append(sys.path[0] + '/..'), thus fixing the imports sopare.log, sopare.config, and sopare.audio_factory.

I'm not sure whether other people experience this problem -- I'm running ubuntu 18.04 with python 2.7 (the default, I presume). This is my first issue submission, so I hope I've done it all right.

[bishoph]

What version are you running and how does your directory structure looks like? Please provide the complete command lines after starting incl. the error messages.

I have no idea why you get the error but my gut feeling tells me that your solution is not for the majority of users...

[ajwells256]

Attached are two text files. error_message.txt details the error message (it's pretty standard for python) as well as some of the debugging I went though to find my solution; directory.txt shows my directory structure (it's exactly the same as the current branch, as I merely git cloned it).

Have you tried running the commands on a machine with the master branch's directory structure? I would be astounded if it worked on anyone's machine in its current state, but I'm certainly no expert on python.

error_message.txt directory.txt

Also, I haven't looked yet, but it occurs to me that there may be similar bugs (or "bugs") in the other test scripts

[bishoph]

Please provide version information for SOPARE and Python and are you using a virtual environment?

[ajwells256]

My mistake, I was incorrect with my first diagnosis. The real issue is the name of the root directory. If you download the code as a zip, it comes out as sopare-master; if you git clone it, it comes out as sopare. By changing the name from sopare to sopare-master, you can break the imports. The attached text file shows the terminal output for me doing this.

As mentioned above, I've been using the latest sopare and my python is 2.7 and I'm running Ubuntu.

directoryName.txt

[bishoph]

Sure, the import for the lib "sopare" must be places and located in the directory named "sopare".

Closing issue.

[ajwells256]

I personally would make sure that the code worked out of the box whether cloned via git or downloaded as a zip, but I guess that's up to you to decide.

[bishoph]

Sure. I currently have no idea how to make sure that the zip works out of the box other than move the whole repository one level up in a newly created directory called sopare...

If anybody has a tip how to solve this easily please comment here :)