search

bishopmatthew / HackerNews

An open source Hacker News client for Android.
230 stars 61 forks source link

Rotating the screen causes the embedded browser to refresh #40

Closed ucarion closed 10 years ago

ucarion commented 10 years ago

When I visit an article through the app and rotate my screen, the page refreshes (which can cause quite a bit of delay sometimes). The real annoyance with this is that if I look at an article and then click on a link, causing a rotate event will reload first page (that is, the page linked to from HN) is what's loaded, instead of the one I was just on.

Really great job on this app, though. It's a pleasure to use!

pkillian commented 10 years ago

Confirmed bug; it irritates me too. I'll look into a few different ways to cache a breadcrumb trail in the integrated browser, and fix the rotate issue if I can. I think it's a matter of making sure onOrientationChanged(int) gets triggered and doesn't just naively call a new load of the same document.

Will look into this before the New Year, but don't expect much progress until next week or so.

Thanks! Patrick

pkillian commented 10 years ago

Changes merged with master; should be released to Google Play soon.

Thanks! Patrick

ucarion commented 10 years ago

Awesome, @pkillian . Thanks!