search

bismuthfoundation / BismuthRPC

[Released] A Json-RPC Server for Bismuth Crypto Currency
GNU General Public License v3.0
7 stars 8 forks source link

Remove need for globals, tiny minor improvements #2

Closed Aareon closed 6 years ago

Aareon commented 6 years ago

Not to bash, but why do we insist on using globals when they are so widely discouraged due to safety reasons? Is the intention not to be safe?

EggPool commented 6 years ago

Thanks for the global var integration. The sarcasms could have been left out.

I do welcome functional edits & ideas, but please, refrain from cosmetic/style changes only. I can autoformat the code if I want to. Adding a space there or splitting a single line into 10 does not help. Only adds noise to the PR and stresses the mouse :) The mockup objects are on a single line for a reason.

Aareon commented 6 years ago

Fair enough, duely noted. I apologize for the sarcasm. Been a long day lol

EggPool commented 6 years ago

Code updated without global, thanks or the help, closing this pr.

EggPool commented 6 years ago

Passing the config var this way breaks the Tornado server.

Current git code is then broken, working on it.

EggPool commented 6 years ago

Fixed with proper init syntax. Closing again.