Release 6.0.3 is not available on pypi

bisohns / search-engine-parser

Lightweight package to query popular search engines and scrape for result titles, links and descriptions

https://search-engine-parser.readthedocs.io

459 stars 87 forks source link

Closed Przemek625 closed 3 years ago

Przemek625 commented 3 years ago

Currently I can not install new release 6.0.3 with pip because it is not available on pypi.

MeNsaaH commented 3 years ago

@deven96 we need to update the deploy scripts to check if the tag and the version are the same.

MeNsaaH commented 3 years ago

I've released a newer version and updated the scrpits. Shoudn't happen in future

deven96 commented 3 years ago

What if we push a tag and it fails to deploy (perhaps cuz test fails), isn't that tag effectively wasted? @MeNsaaH

MeNsaaH commented 3 years ago

The tag action doesn't run tests. I just deploys

deven96 commented 3 years ago

The tag action doesn't run tests. I just deploys

Doesn't that mean we can trigger a tag despite failing tests?

MeNsaaH commented 3 years ago

Yeah. But why would you do that? You push a tag when you are comfortable with what is on the branch