Open rodvar opened 3 weeks ago
this might be a good candidate to add KMP Koin lib for DI and grow from there (optional for now)
this will be tackled partially by and after finishing https://github.com/bisq-network/bisq-mobile/issues/6 so that we have a clear understanding on both worlds (xClients
and androidNode
)
this will be tackled partially by and after finishing #6 so that we have a clear understanding on both worlds (
xClients
andandroidNode
)
after doing the above, came to the conclusion that this is not that important at the moment. So I'm downgrading the priority in favor of settings the grounds for the shared repositories
concept we are discussing on matrix.
the androidNode networking foundation has been laid with the closed issue #6 , further development will continue in a per use-case base
Next steps and update on this issue now that we have a clearer picture of the overall architecture, this becomes basically developing the networking for the xClients
cause the androidNode
can grow individually. This is thanks to the way in which we implemented MVP.
KTor
so that services can incorporate the httpClient
to do requests when needed (eventually wss when we figured out bisq-api
).on the android node side there is some stuff to do but can be done independently whilst working each of the features.
we are starting to work this out here
https://github.com/bisq-network/bisq-mobile/pull/62
after merge there will be a refactor to finish it up (move the shared networking stuff in a way that doesn't affect the androidNode)
to keep things moving we to put ktor into the domain submodule for now. Enhancement refactor will be done to make it separate so that the androidNode does not carry that unnecessary networking in the build
Follow up to https://github.com/bisq-network/bisq-mobile/issues/10
This issue has the following goals:
xClients
apps (android and iOS) will have the same time of https networking, so first goal for this task is to create that and make sure its only used in these 2 apps.androidNode
app will have its own complex networking provided by bisq2 jars (this issue is the opportunity to start understanding how that works to be able to isolate it from the app design architecture)