bisq-network / bisq-mobile

2 stars 4 forks source link

Apps Networking Architecture #18

Open rodvar opened 3 weeks ago

rodvar commented 3 weeks ago

Follow up to https://github.com/bisq-network/bisq-mobile/issues/10

This issue has the following goals:

rodvar commented 3 weeks ago

this might be a good candidate to add KMP Koin lib for DI and grow from there (optional for now)

rodvar commented 2 weeks ago

this will be tackled partially by and after finishing https://github.com/bisq-network/bisq-mobile/issues/6 so that we have a clear understanding on both worlds (xClients and androidNode)

rodvar commented 1 week ago

this will be tackled partially by and after finishing #6 so that we have a clear understanding on both worlds (xClients and androidNode)

after doing the above, came to the conclusion that this is not that important at the moment. So I'm downgrading the priority in favor of settings the grounds for the shared repositories concept we are discussing on matrix.

the androidNode networking foundation has been laid with the closed issue #6 , further development will continue in a per use-case base

rodvar commented 1 week ago

Next steps and update on this issue now that we have a clearer picture of the overall architecture, this becomes basically developing the networking for the xClients cause the androidNode can grow individually. This is thanks to the way in which we implemented MVP.

  1. shared/networking module using KTor so that services can incorporate the httpClient to do requests when needed (eventually wss when we figured out bisq-api).
  2. create a BaseService that gets the client inyected with some basic helper methods that every service will use
  3. the base service will need the settings repository to get info about the trusted node to connect to.

on the android node side there is some stuff to do but can be done independently whilst working each of the features.

rodvar commented 3 days ago

we are starting to work this out here

rodvar commented 16 hours ago

to keep things moving we to put ktor into the domain submodule for now. Enhancement refactor will be done to make it separate so that the androidNode does not carry that unnecessary networking in the build