search

bisq-network / bisq-website

@bisq-network website at https://bisq.network
34 stars 76 forks source link

Fix and optimize image alt tags for better SEO #321

Closed RiccardoMasutti closed 4 years ago

RiccardoMasutti commented 4 years ago

This will boost traffic and SEO (Search Engine Optimization) for Bisq.network.

It's extremely important to give images good alt attributes: alt text strengthens the message of website pages with search engine spiders and improves the accessibility of it.

m52go commented 4 years ago

@RiccardoMasutti these are good edits, but the index.html page is never actually rendered to the user, so these edits won't ever take effect.

Hence my other PR #279 to get rid of that page altogether...review appreciated :)

As for this PR, the changes should be made in the other files that are actually rendered like homepage_content.html, os_selector_options.html, etc.

I know this isn't intuitive...refactoring is needed.

RiccardoMasutti commented 4 years ago

@m52go ready to merge

RiccardoMasutti commented 4 years ago

@m52go ty for review. fixed

m52go commented 4 years ago

@RiccardoMasutti there was still a mistake. Testing in your local browser would easily help find these kinds of issues.

Screenshot from 2020-01-27 16-16-31

m52go commented 4 years ago

ACK