search

bisq-network / bisq-website

@bisq-network website at https://bisq.network
35 stars 76 forks source link

Add <a> title attribute to os selector #350

Closed RiccardoMasutti closed 4 years ago

RiccardoMasutti commented 4 years ago

Meta title tags are a major factor in helping search engines understand what pages are about. Title tags are used in three key places:

m52go commented 4 years ago

@RiccardoMasutti did we discuss priority or budget for #350, #349, #348, and #347?

RiccardoMasutti commented 4 years ago

@m52go no we didn't. I proposed those changes without defining the budget because they are all low-budget changes; I thought I'd discuss it with you once all the PRs were added

m52go commented 4 years ago

With your request history, I'm not sure what "low-budget" means. Also it takes time and and effort for reviewers to review, and your past PRs have taken lots of time to review and fix, so your time and budget is not the only consideration.

Above all, this isn't the general workflow in place for growth. Compensation and priority must be determined before making pull requests. Specifically for you, we decided you'd make issues before making any pull requests—right?

I would have rejected the notion of making these changes if you had run them by me beforehand, so I'm rejecting them here.