search

bisq-network / bisq-website

@bisq-network website at https://bisq.network
34 stars 76 forks source link

Add search to website #369

Closed stevavoliajvar closed 3 years ago

stevavoliajvar commented 4 years ago

Bisq website would be much better with a search.

Since this site is static there are ways to implement search with using minisearchjs. I have experience in implementing it, implemented here, and would like to make it work for bisq website if bisq community is ok with it.

Roughly technical process would consist in building an index file, search form and appropriate javascript code.

m52go commented 4 years ago

@stevavoliajvar hey thanks for the offer.

We're very close to rolling out a wiki, which will become the go-to resource for information about Bisq. That will probably lead to the website being simplified soon afterward, so I don't know if adding search would be worth the effort.

Is there anything in particular that you important but hard to find? It might be helpful to know as we structure the wiki and/or restructure the website.

stevavoliajvar commented 4 years ago

Fair point.

Then I'd suggest, since wiki has search, to make search input field on website routes to wiki search via action attribute in HTML.

m52go commented 3 years ago

Now that wiki is in more active use, maybe we could do this. @stevavoliajvar would you be interested?

Main thing on my mind is figuring out a place to put the search box. Site is already so crowded...

I imagine it opening a new window with wiki search results.

stevavoliajvar commented 3 years ago

@m52go i see this just now, I would like to do this.

The place can be a simple looking glass icon before change theme icon that would open search prompt, either full screen or just spread out input field. Then that form is connected with bisq.wiki search and redirects user to there.

m52go commented 3 years ago

That sounds good. I think a spread-out input field would be better. Should results open in a new tab, since wiki is a different site?

stevavoliajvar commented 3 years ago

@m52go I think it should because it takes user to a new webstite, so previous one still gets opened. But if people don't like it then we can easily revert back to the same tab.

I will report within a week from now regarding this issue.

stevavoliajvar commented 3 years ago

@m52go here is the preview and a pull request

I decided to just put a simple search field in the end, because other solution with full screen search would require JavaScript which is not necessary and overkill in my opinion.

m52go commented 3 years ago

Done with #418.