Add search to menu bar - Githubissues

bisq-network / bisq-website

@bisq-network website at https://bisq.network

34 stars 76 forks source link

Add search to menu bar #411

Closed stevavoliajvar closed 3 years ago

stevavoliajvar commented 3 years ago

Added search field that is connected to bisq.wiki search.

m52go commented 3 years ago

Hey thanks for the effort!

Few notes:

search results don't seem to open in a new tab
styling
- positioning: seems a little sloppy at the moment; too close to language selector and too far from dark mode toggle [0]
- styling: seems to be taking on hover effects of other nav menu items (e.g., underlining)
- dark mode: background color should probably be a bit darker, maybe #1a1a1a

Screenshot from 2020-12-20 09-22-11

m52go commented 3 years ago

Also I wonder if it would be good to include a submit button somewhere for usability. I imagine most touch/mobile devices will be able to execute search via keyboard but not sure...

m52go commented 3 years ago

@stevavoliajvar will you be able to implement updates?

m52go commented 3 years ago

Closing as stalled. Feel free to re-open if/when you'd like to follow it through.