bisq-network / bisq

A decentralized bitcoin exchange network
https://bisq.network
GNU Affero General Public License v3.0
4.7k stars 1.27k forks source link

Settings | Network Info | Bitcoin network #1550

Closed ghost closed 6 years ago

ghost commented 6 years ago

On a Bisq-0.7.0 debian 64 bits, In the Settings | Network Info | Bitcoin network tab, Connected peers: The mentionned onion addresses are repeated. 1st address, repeated 3 times 2nd address, repeated 3 times 3rd and last address mentionned, repeated 2 times.

Not sure if this is really wanted ?

ManfredKarrer commented 6 years ago

Which mentionned onion addresses? Can you post a screenshot?

ghost commented 6 years ago
[c6ac4jdfyeiakex2.onion]:8333
[c6ac4jdfyeiakex2.onion]:8333
[c6ac4jdfyeiakex2.onion]:8333
[vlf5i3grro3wux24.onion]:8333
[vlf5i3grro3wux24.onion]:8333
[vlf5i3grro3wux24.onion]:8333
[vlf5i3grro3wux24.onion]:8333
[sjyzmwwu6diiit3r.onion]:8333
[sjyzmwwu6diiit3r.onion]:8333
ghost commented 6 years ago

bisq-22052018a

ManfredKarrer commented 6 years ago

So at the BTC nodes you get the same nodes multiple times. That's weird. How long have you running Bisq without restart? Did you had network issues? After a restart you should have no duplicate BTC nodes there.

ghost commented 6 years ago

How long have you running Bisq without restart?

Bisq was launched at 11:30 the same day, so just a few hours

Did you had network issues?

The PC running Bisq gets internet thru wifi(box) + wifi (local), so network issues are possible. But, on the same time, the P2P network, as showed in Settings|Network Info has no duplicates

fwiw, in the log there is this kind of message mai-23 00:58:56.254 [BlockingClient network thread for c6ac4jdfyeiakex2.onion:8333] INFO o.b.core.Peer: Received alert from peer [c6ac4jdfyeiakex2.onion]:8333: URGENT: Alert key compromised, upgrade required

I'll try to have a better look at the log file, but it's a huge (2.5MB) file. Should I search for some specific things ?

After a restart you should have no duplicate BTC nodes there.

I'll restart Bisq and see

ghost commented 6 years ago

I have moved the PC on a better place for wifi reception. I have restarted Bisq ... and there are now 9 nice BTC peers, all different. So, things seem ok.

ManfredKarrer commented 6 years ago

That "Alert key compromised, upgrade required" message is a misleading warning. It is just that in Bitcoin they removed the Alert feature a while ago... so you can ignore that.

You can observe it a bit if it appears again that you get duplicated BTC nodes. It is not terrible bad just meaning you have less different nodes connected to, so less redundancy but should not be the case. Probably at connection loss and re-connects there are some issues in the code that it does not ignore already connected peers for new connection attempts. Though that is inside BitcoinJ and we don't have a dedicated dev for that area atm.

ghost commented 6 years ago

Thanks for your explanations and your time Manfred.

ManfredKarrer commented 6 years ago

Closed as not reproduceable

ghost commented 6 years ago

I continue to have this issue on a regular basis. But, as said, my connection is wifi + wifi, so I believe this may well be the real reason.

ManfredKarrer commented 6 years ago

Ok, I reopened it for further investigation. Seems that at connection loss you reconnect to the same peers.

ManfredKarrer commented 6 years ago

Fixed