bisq-network / bisq

A decentralized bitcoin exchange network
https://bisq.network
GNU Affero General Public License v3.0
4.7k stars 1.27k forks source link

Normalize Phone Numbers #3042

Closed kdeldycke closed 4 years ago

kdeldycke commented 5 years ago

Just happened to have an issue on setting up a new Revolut account on Bisq: the phone number I registered is taken as-is and will be displayed as such to the receiving end of the transaction.

I entered my Revolut account's phone number in the local (French) format, i.e. 0612345678 and the other party, not located in the same country as I am, did not find my account. It had to be formatted in the international form: + 33 6 12 34 56 78.

I failed my first transaction on Revolut for that reason. But was able to solve the dispute thanks to a great arbitrator.

To fix this issue for good and reduce the number of disputes, I propose to have all phone number fields in Bisq normalised into their international form.

Good news, there's a great library made by Google to normalise all of them at: https://github.com/google/libphonenumber . Used it myself, it's solid, well maintained and clean! :)

ghubstan commented 5 years ago

I'm working on a validator / formatter and tests for this issue. Please let me know what objections there are to this approach:

ripcurlx commented 4 years ago

Closing as complete