search

bisq-network / bisq

A decentralized bitcoin exchange network
https://bisq.network
GNU Affero General Public License v3.0
4.69k stars 1.26k forks source link

Ui integration for support Trezor, Ledger, Keepkey and status-keycard #3360

Open danimesq opened 4 years ago

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 4 years ago

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

danimesq commented 4 years ago

@freimair

chriscrutt commented 2 years ago

please

MarekPasnikowski commented 2 years ago

This is an amusing discussion to an outsider like me.

Anyway, I own a Trezor and I refuse to use any software without integrated support for hardware wallets. The wiki has only one mention of a hardware wallet use.

Do not send BSQ to hardware wallets.

Is there any chance to encourage a prioritized integration of Trezor in Bisq? One idea I have is I could buy a significant amount of BSQ to fund the feature development.

ripcurlx commented 2 years ago

This is an amusing discussion to an outsider like me.

Anyway, I own a Trezor and I refuse to use any software without integrated support for hardware wallets. The wiki has only one mention of a hardware wallet use.

Do not send BSQ to hardware wallets.

Is there any chance to encourage a prioritized integration of Trezor in Bisq? One idea I have is I could buy a significant amount of BSQ to fund the feature development.

Thanks for the offer to fund this development, but it is more suited for Bisq2, which is already under development: https://github.com/bisq-network/bisq2

MarekPasnikowski commented 2 years ago

I had no idea about the version 2. I will take a look at it.

MarekPasnikowski commented 2 years ago

I have given this issue some time to think about it. I can see two distinct problems to solve:

  1. Implementation of BSQ tokens in the hardware wallets. This is the Trezor's Wiki page about new coins.

    This is what I am most interested in. I could tolerate keeping the small amounts of cryptocurrency I would want to trade outside of Trezor. However, I will not compromise the security of the long term holdings, which would include BSQ.

  2. The actual integration of hardware wallets in the BISQ application. This implies exclusive usage of hardware keys in all transactions. Definitely a big project and makes a lot of sense to do it in the BISQ2 version.

In conclusion, my main question is:

How to approach the implementation of BSQ in Trezor, and other wallets?