bisq-network / bisq

A decentralized bitcoin exchange network
https://bisq.network
GNU Affero General Public License v3.0
4.67k stars 1.26k forks source link

Fix numbers alignment in GUI #3991

Open freimair opened 4 years ago

freimair commented 4 years ago

Description

Not a bug per-se, but really not up to standards and expectations.

Numbers have to be aligned by comma. Only so can one easily assess the number and its relation to the numbers next to it. Especially when it comes to finances.

Given I am a heavy trader and I see that a software does not even manage to display monetary numbers professionally, i would not even bother using the software + if someone asks me, I would immediately tell them so.

Expected behaviour

Screenshot from 2020-02-19 13-16-27_fixed

Actual behaviour

Screenshot from 2020-02-19 13-16-27

There are other places in the GUI where the same thing happens. Seems like an easy fix though.

ripcurlx commented 4 years ago

There was an alignment solution in place in the past when using a monospace font for this columns when having them left aligned. In this specific case we could just right align them, but for nearly all other tables where the columns should be left aligned there is no way around using a monospace font to solve this. Monospace was ditched because of aesthetic reasons.