dcod3d commented 4 years ago

3316 # Description

I am unable to complete the trade after the buyer has sent payment.

Version

1.2.8

Steps to reproduce

Clicked "CONFIRM PAYMENT RECEIPT" > "YES, I HAVE RECEIVED THE PAYMENT"

Expected behaviour

Confirm trade and return deposits

Actual behaviour

Error pop up

Device or machine

macos catalina

Additional info

Log excerpt with some redactions:

Not able to find peers witness, unable to sign for trade {} [Trade{ offer=Offer{getErrorMessage()='null', state=UNKNOWN, offerPayload=OfferPayload{ id='XGBPTWXB-ace77ac8-87c8-4ade-93ea-3f21ad86c682-127', date=Fri Feb 21 20:24:03 CST 2020, ownerNodeAddress=############.onion:9999, pubKeyRing=PubKeyRing{signaturePubKeyHex=308201b83082012c06072a8648ce3804013082011f02818100fd7f53811d75122952df4a9c2eece4e7f611b7523cef4400c31e3f80b6512669455d402251fb593d8d58fabfc5f5ba30f6cb9b556cd7813b801d346ff26660b76b9950a5a49f9fe8047b1022c24fbba9d7feb7c61bf83b57e7c6a8a6150f04fb83f6d3c51ec3023554135a169132f675f3ae2b61d72aeff22203199dd14801c70215009760508f15230bccb292b982a2eb840bf0581cf502818100f7e1a085d69b3ddecbbcab5c36b857b97994afbbfa3aea82f9574c0b3d0782675159578ebad4594fe67107108180b449167123e84c281613b7cf09328cc8a6e13c167a8b547c8d28e0a3ae1e2bb3a675916ea37f0bfa213562f1fb627a01243bcca4f1bea8519089a883dfe15ae59f06928b665e807b552564014c3bfecf492a0381850002818100dddbcae4a8a89df923e4b993c11ba1680392ac5aaae88ccdcb300b90fb8a0055f22717a4a018edb58945a4f0ca54d18e65032ef84c79def435a20a548b1a05e64c6ae5d88361698ecb44f350f139fec97ae56a7becfe8f55dd07b234ae5e505eca4ced00182e62e8588fd28bc70d0e55dc809e147eed8ef31b5d4e060e66ac46, encryptionPubKeyHex=30820122300d06092a864886f70d01010105000382010f003082010a0282010100adcbfb6e962bc15fe612948ec3a0c5d40946aae55316ebd0c49725cab70e0d167dea5f008032258b36fa0a99c7c084238e575d826a0c73406f315bbaa9dc6160003c284c7f0281a66028dbbce5874476e7492c4af023907c1ed7ca8a05ab2b6fc29e2f2755ede4ef46a3dfc0fdc6f7de0210d32baabd76872649fd55befc6790e16be44f89398284c282e7508b16469637d3ac3e36a8fc8fda87819d85753062a54ebccfe58e8a115071bceb5bd167d848357a0949adec104edf81e5be947ea30ce8bea2c6b45b6d7d02a6a57f0e5501c8858d44bbf4cda7cb2f28abf14118d7c2b077c3f0e9140d87c85275570de17801dda31d4d9d66f38cf0f7cc035fd4670203010001}, direction=SELL, price=72521670, marketPriceMargin=0.3, useMarketBasedPrice=true, amount=1000000, minAmount=1000000, baseCurrencyCode='BTC', counterCurrencyCode='USD', paymentMethodId='CLEAR_X_CHANGE', makerPaymentAccountId='##################', offerFeePaymentTxId='a0e4635b2c25487737fde2d94f3ca88a59cc0b49235a75b5dd0a53ff6dbd8766', countryCode='null', acceptedCountryCodes=null, bankId='null', acceptedBankIds=null, versionNr='1.2.7', blockHeightAtOfferCreation=618442, txFee=4100, makerFee=10, isCurrencyForMakerFeeBtc=false, buyerSecurityDeposit=600000, sellerSecurityDeposit=600000, maxTradeLimit=25000000, maxTradePeriod=345600000, useAutoClose=false, useReOpenAfterAutoClose=false, lowerClosePrice=0, upperClosePrice=0, isPrivateOffer=false, hashOfChallenge='null', extraDataMap={capabilities=0, 1, 2, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, accountAgeWitnessHash=d18e4e2fc643fdfbfca172133b3962b680cabe43}, protocolVersion=2 }}, isCurrencyForTakerFeeBtc=true, txFeeAsLong=4560, takerFeeAsLong=6000, takeOfferDate=1584228226158, processModel=bisq.core.trade.protocol.ProcessModel@77a4042a, takerFeeTxId='5827d0854abd71d64eac42081dfdf3d59554d62982592b6f09595d086faab4f9', depositTxId='a682ff9eb1c508db44c7071accd3146f97c36240b3c38beda232bb557064e5e1', payoutTxId='null', tradeAmountAsLong=1000000, tradePrice=66164540, tradingPeerNodeAddress=###############.onion:9999, state=SELLER_CONFIRMED_IN_UI_FIAT_PAYMENT_RECEIPT, disputeState=NO_DISPUTE, tradePeriodState=FIRST_HALF, contract=Contract{ offerPayload=OfferPayload{ id='XGBPTWXB-ace77ac8-87c8-4ade-93ea-3f21ad86c682-127', date=Fri Feb 21 20:24:03 CST 2020, ownerNodeAddress=###################.onion:9999, .... txFee=4560, takerFee=6000, storage=bisq.common.storage.Storage@198fb117, btcWalletService=bisq.core.btc.wallet.BtcWalletService@7364b242, stateProperty=ObjectProperty [value: SELLER_CONFIRMED_IN_UI_FIAT_PAYMENT_RECEIPT], statePhaseProperty=ObjectProperty [value: FIAT_RECEIVED], disputeStateProperty=ObjectProperty [value: NO_DISPUTE], tradePeriodStateProperty=ObjectProperty [value: FIRST_HALF], errorMessageProperty=StringProperty [value: null], tradeProtocol=bisq.core.trade.protocol.SellerAsMakerProtocol@69a5faf6, depositTx= a682ff9eb1c508db44c7071accd3146f97c36240b3c38beda232bb557064e5e1 updated: 2020-03-14T23:23:53Z included in best chain at: 2020-03-15T02:08:07Z in PUSHDATA(72)[3045022100c06d0647450ee3b9837d75c92511d798b0246e35328a410c3e81440933d54f780220691d9632aeb83f1fed9f36b986df8d8b79cd572ced83f7ea89acb92e223aa0b001] PUSHDATA(33)[0361a0ad9bd4ad083a047ee169b59386b6ee89f1145de0f0d8ce58ad25e80c6995] outpoint:5827d0854abd71d64eac42081dfdf3d59554d62982592b6f09595d086faab4f9:1 in PUSHDATA(72)[304502210089a2464c91010ff24f4dd2063fdd4e1bbcc0950818068f48a15f02ba7d7297f202202288a42cca8b8153ae1d93c8e380401230d22ab25e1e0cda4c48735e963f284c01] PUSHDATA(33)[02816a0e391c06ae68dd8d9ea2b3d5113fc9f77ef9a8780f795539db9532a5a94f] 0.016 BTC (1600000) outpoint:a0e4635b2c25487737fde2d94f3ca88a59cc0b49235a75b5dd0a53ff6dbd8766:1 hash160:ba179e1c69cc6d2fa0b8d0a88e2b71835c1bb687 out HASH160 PUSHDATA(20)[c0d4c57d8c8f2ed7c2d2c5accb46d7abf56a453b] EQUAL 0.0220456 BTC (2204560) ScriptPubKey: a914c0d4c57d8c8f2ed7c2d2c5accb46d7abf56a453b87 Address:3KGcYzdmS6ZeYF1KtQ3b7XDbbiid9iMwGn out RETURN PUSHDATA(32)[5aab8c5f97ffe5dde4c482c9f8a7f649f0202055116d2b9fd6221654cbe84cbe] 0.00 BTC (0) ScriptPubKey: 6a205aab8c5f97ffe5dde4c482c9f8a7f649f0202055116d2b9fd6221654cbe84cbe Address:[exception: Cannot cast this script to a pay-to-address type] prps UNKNOWN , delayedPayoutTx=null, payoutTx=null, tradeAmount=1000000, tradeAmountProperty=null, tradeVolumeProperty=null, decryptedMessageWithPubKeySet=[], mediationResultState=UNDEFINED_MEDIATION_RESULT, mediationResultStateProperty=ObjectProperty [value: UNDEFINED_MEDIATION_RESULT], lockTime=624544, delayedPayoutTxBytes=0100000001e1e5647055bb32a2ed8bc3b34062c3976f14d3cc1a07c744db08c5b19eff82a600000000da00483045022100e58263c3aee347f1a2a0e8b7863a0882f352fb05372dfe8f476d40be2fd22e3d02204a5f9e444840af0a5ef017593bea010b1307c06ea82047a061e4eda2806bf4b80147304402200b0d0529446280ac4f23cece5720f57472821a2cf9efec1828448749ed1076bd02204fff0528b09745b3c1c5795c608722fde204999507236158a7df6cd65cb37ed20147522102ead2476703a286a8fdde7e6d29a41eeafd1609834dec9e971aa04488f526a5482103183f1c19b466f4bcf79a7158b76258625e40fcd5534dee3b2834871d518f057652aefeffffff01c09121000000000017a9145c95d9cf9d48683284dff53379acc296eb21488387a0870900, refundAgentNodeAddress=##############.onion:9999, refundAgentPubKeyRing=PubKeyRing{signaturePubKeyHex=308201b83082012c06072a8648ce3804013082011f02818100fd7f53811d75122952df4a9c2eece4e7f611b7523cef4400c31e3f80b6512669455d402251fb593d8d58fabfc5f5ba30f6cb9b556cd7813b801d346ff26660b76b9950a5a49f9fe8047b1022c24fbba9d7feb7c61bf83b57e7c6a8a6150f04fb83f6d3c51ec3023554135a169132f675f3ae2b61d72aeff22203199dd14801c70215009760508f15230bccb292b982a2eb840bf0581cf502818100f7e1a085d69b3ddecbbcab5c36b857b97994afbbfa3aea82f9574c0b3d0782675159578ebad4594fe67107108180b449167123e84c281613b7cf09328cc8a6e13c167a8b547c8d28e0a3ae1e2bb3a675916ea37f0bfa213562f1fb627a01243bcca4f1bea8519089a883dfe15ae59f06928b665e807b552564014c3bfecf492a0381850002818100e2d5650b1114edb1677c4bd06a0dc9ba1bcf437b249a3f19aa888cc28d7160864bab2a35c7b5ad4b5515f51984186309255f9637b61242793e7c4eb31ba1dc4349689c55b9842627542b12ddad13c4f6e703fb253836837011d307852ac51362763c2bdfd45a747eac48ae5b3ba161c52afd5721c84c7adbbb19130998d071b6, encryptionPubKeyHex=30820122300d06092a864886f70d01010105000382010f003082010a0282010100c4f5ee636bd383852166637f30d5007759e102194658782cb3f259fc0dea1bfbea0572f453cca18ff90bce215afd99f4bcb965cafb1139e7b6106ced9b9022d5f1d415ea8c0a0875391b07a65921b9f0303ca2b3622a1bc264c390b9668cd3ce2670725e09c236ce3ef23051eb509bec1fb49da4776beb9ae5162d6c37b1f0bb43836587cf38b51639667966f2b5db65e23a74ceb322414a535721f0af8d31ac91ff1d419f9d7b90d8be89e43c7e8670aacde7304439ff8ffd8ce956763bd35a67f97209224f5b5c3afc2211dd070787f4c926f98d9e3b5947f6da5dfdbc69e449455533e3d71c91e8f2f2ca2aae8d717c441180272301a091bd7d349cb5d1dd0203010001}, refundResultState=UNDEFINED_REFUND_RESULT, refundResultStateProperty=ObjectProperty [value: UNDEFINED_REFUND_RESULT], lastRefreshRequestDate=1584228226158 }]

atom-mota commented 4 years ago

I'm the taker of this btc buy offer and I have experienced this issue with other USD trades ( not with Euros ) I mentioned this on https://bisq.community/t/recurring-locked-btc-from-seller-on-buy-offers-i-take/9059/7 I'm using Bisq v1.2.7 Network version: 1; P2P message version: 10; Local DB version: 1; Trade protocol version: 2 Mac OS 10.15.3

huey735 commented 4 years ago

ping @ripcurlx

ripcurlx commented 4 years ago

@sqrrm As you are already investigating not signed witness trades, maybe you'll spot the problem faster.

dcod3d commented 4 years ago

This trade was resolved with the mediator doing the payout manually, but will keep this open since the underlying issue still exist. One thing I noticed was the buyer account’s age was showing/stuck on 0 days in the support screen.

sqrrm commented 4 years ago

The signer couldn't find the AccountAgeWitness of the signee. I haven't seen this before, and the AccountAgeWitness code is quite old and has seemed robust until now.

The seller verifies the AccountAgeWitness before proceeding with initiation of the trade so this is indeed quite curious. Was there any earlier warnings or other strangeness during the earlier steps of this trade?

dwknch commented 4 years ago

Hello I found this issue via search in issues, because I just experienced the same issue.

Using Bisq version 1.3.4
Shutting down and restarting Bisq didn't resolve the issue
Similar to previous comment by @ncstdc: buyer account's age shows as "Age not known" (something I had never observed with any account before - and I already performed many trades in Bisq)

Please someone advice how to proceed, I'm no regular github user and not familiar with the processes here. Is it really necessary to create a new issue as prompted by the dialog in Bisq?

leo816 commented 4 years ago

I had the same issue with a user today using v1.3.4