search

bisq-network / bisq

A decentralized bitcoin exchange network
https://bisq.network
GNU Affero General Public License v3.0
4.71k stars 1.27k forks source link

More than 2 tickets for the same trade #4847

Open huey735 opened 3 years ago

huey735 commented 3 years ago

Description

A single trade has more than two dispute tickets open.

Version

Bisq v1.5.0

Steps to reproduce

Unable to reproduce.

Expected behaviour

A trade should have only two dispute tickets open. One for the Buyer and the other for the Seller.

Actual behaviour

A single trade has three open dispute tickets. Two for BTC Seller/Taker and one for BTC Buyer/Maker. This is the first instance I've come across so other permutations may be possible. The trade details for all of these trades remain the same. However in one of the BTC Seller/Taker's chat it says that they opened the dispute and in the other it says that it was the other trader who did it.

Device or machine

Pop!_OS 18.04 LTS

Additional info

I have yet to get feedback from the traders regarding the bug.

chimp1984 commented 3 years ago

Does the seller has also 2 trade entries or just one?

chimp1984 commented 3 years ago

I assume it might be related to multiple trades with same offer Id. We should use the new uid in trade instead of offer Ids for other areas as well. See https://github.com/bisq-network/bisq/pull/4889/commits/8f99ca0b6355405eb83d54ea604b4edf61013975