search

bisq-network / bisq

A decentralized bitcoin exchange network
https://bisq.network
GNU Affero General Public License v3.0
4.68k stars 1.26k forks source link

Deposit tx not shown as confirmed in pending trades though it is confirmed #4870

Open chimp1984 opened 3 years ago

chimp1984 commented 3 years ago

Description

The deposit tx is in state pending but it is confirmed in a block explorer. It shows pending in all views (pending trade, trade details and tx list). I think there have been some reports from other users as well about that.

Version

1.5.0

@oscarguindzberg Any idea what can be the reason for that?

oscarguindzberg commented 3 years ago

Could you provide this information:

If other users have the "same" problem we can ask those questions and see if there is a pattern.

In any case, it is hard to investigate without a list of steps to reproduce the bug.

chimp1984 commented 3 years ago

Could you provide this information:

* Is maker fee paid in btc or bsq?

BSQ

* Is taker fee paid in btc or bsq?

BTC

* Does maker see the tx unconfirmed?

Yes

* Does taker see the tx unconfirmed?

He marked payment sent, so seems he see it confirmed.

* Is maker seller or taker?

Maker is seller.

* Do you remember this situation prior to 1.5.0?

No I am not aware of that issue earlier. Maybe 1.4.2. Best to ask support guys if they had cases. 

* Does it fixes after several confirmations?

Have let it running a while but was not changing.

* Does it fixes by restarting Bisq?

No.

* Can taker/maker broadcast another btc tx? does it get confirmed?

Yes.

* Does it happen with every trade for those traders?

No.

If other users have the "same" problem we can ask those questions and see if there is a pattern.

In any case, it is hard to investigate without a list of steps to reproduce the bug.

oscarguindzberg commented 3 years ago

Hi, I can't figure out what might be wrong. @stejbac Any idea what can be the reason for this?

chimp1984 commented 3 years ago

I think @MwithM got another report from a user who had the same issue.

chimp1984 commented 3 years ago

We got more user reports about that bug. If it happens for buyer the trade get stuck as he cannot move to step 2 like here: https://github.com/bisq-network/support/issues/582

oscarguindzberg commented 3 years ago

I am investigating https://github.com/bitcoinj/bitcoinj/issues/2070 which may be related

dgyg commented 3 years ago

Could it be that there is currently a general problem in recognizing certain confirmed transactions?

I have a withdrawal transaction that is indicated as pending in Bisq with a popup text saying (seen by 4 peers / 0 confirmation) although the transaction is actually confirmed in the blockchain.

oscarguindzberg commented 3 years ago

@dgyg Do you remember this situation prior to 1.5.0? Does it fixes after several confirmations? Does it fixes by restarting Bisq?

Could you share with me the txid? Please post it here or send me an email.

dgyg commented 3 years ago

My unconfirmed withdrawal issue could be fixed with a "Delete SPV File and Resync".

I supported another user with the problem described in this ticket (missing deposit tx). In that case the "Delete SPV File and Resync" had to be executed twice to solve the problem. First the deposit tx was displayed as unconfirmed. After the first resync the deposit tx disappeared. After the second resync the deposit tx was available and the payment could be confirmed.

The user facing the problem was the maker of a buy offer and paid the Bisq fee with BTC. The taker of the offer did not have any problems.

oscarguindzberg commented 3 years ago

Maybe related https://github.com/bisq-network/bisq/issues/4919

outermeasure commented 3 years ago

I had exactly the same problem in 1.5.4 which is fixed by "Delete SPV File and Resync". The annoying part is that I almost missed the trade period deadline which started in the background.

oscarguindzberg commented 3 years ago

@outermeasure thanks for reporting.

Are there other users experiencing the same problem? It was an everyday issue for many users until it was fixed.

Just for the record, these are the commits that fixed the issue: https://github.com/bisq-network/bitcoinj/commit/1a786a2d1aaf18a19f11032bde9a6b6382b1a18c https://github.com/bisq-network/bitcoinj/commit/bc8d2e791aa073856d83cbac16d4e8f3f7b7f71a

Could this be another problem with the same symptoms?

outermeasure commented 3 years ago

Not sure if this helps, but I updated recently from 1.5.0 to 1.5.4. Did another trade since then and had no issues.