Standardize columns across all sections in Portfolio section in Bisq - Githubissues

bisq-network / bisq

A decentralized bitcoin exchange network

https://bisq.network

GNU Affero General Public License v3.0

4.73k stars 1.27k forks source link

Standardize columns across all sections in Portfolio section in Bisq #5309

Open pazza83 opened 3 years ago

pazza83 commented 3 years ago

Description

The columns providing trade info in the portfolio section in Bisq are not standardized. Some sections provide more details than others. This means some sections are missing information that would be useful.

The Portfolio section in Bisq consists of the following sub sections:

My Open Offers
Open Trades
History
Failed

All sub sections should have the following columns:

Trade ID
Date/Time
Market
Price
Deviation
Amount in BTC
Amount
Transaction fee
Trade Free
Payment method
My Role
Buyer deposit
Seller deposit
Offer type
Status

Currently, for example, it is difficult to work out what the deviation from market price was for a Trade that is in your 'Open Trades' this makes the following difficult:

Working out profit/loss
Suggesting intended outcomes to mediators
Suggesting intended outcomes to arbitrators
Placing a similar offer into the market at the same price

Also all the information above should be included in the 'Trade ID' window when clicking on the (i) for more information

My Open Offers also is the only section with 'Trigger price'. I think this is fine to stay like this.

Also all sections should have an option to export to CSV. It is only 'Open trades' missing this. This would be helpful when wanting to place the same offers again whilst they are still 'open'. Currently this has to be done by copying down the trade data manually.

Version

v1.5.9

Steps to reproduce

Look at portfolio section. Information columns are different.

Expected behaviour

Portfolio section should be consistent with the Information columns.

Screenshots

My open offers

Open trades

history History

Failed Failed

pazza83 commented 3 years ago

Is any @bisq-network/bisq-devs available to do this. Also similar to #5192 and #5277

wallclockbuilder commented 3 years ago

Sign me up

cd2357 commented 3 years ago

Cool @wallclockbuilder 👍

Feel free to submit a PR when you have it ready.

pazza83 commented 3 years ago

Hi @wallclockbuilder how are you progressing with this issue?

pazza83 commented 3 years ago

Hi @xyzmaker123 let me know if you would like to work on this issue.

ghost commented 3 years ago

@pazza83 I can take it

pazza83 commented 3 years ago

Thanks that is great. Let me know if you need anything

fahimahmedx commented 2 years ago

Any devs currently working on this issue @xyzmaker123 @pazza83? Wondering if you hit any roadblocks. I'm a noob, but I want to try taking a crack at this!

ghost commented 2 years ago

AFAIR I was researching possibility of implementing it but I realized that it's not that obvious - f.e. records for completed trades (history) contains some fields not present in open offers etc. I think slight adaptation is possible, but 100% standarization rather not.

@fahimahmedx I'm not planning to work on this topic in the nearest future - feel free to take it. Please let us know about progress.

fahimahmedx commented 2 years ago

"Get set up to Sign your Git Commits with GPG. Any commits to any Bisq repository must be signed." I forgot to sign my commits, is there a simple way to amend previous comments to sign them?

ghost commented 2 years ago

@fahimahmedx try one of suggestions from this thread: https://superuser.com/questions/397149/can-you-gpg-sign-old-commits

fahimahmedx commented 2 years ago

How can I test the Open Trades column without having to make open trades myself?

ghost commented 2 years ago

@fahimahmedx You need to run local Bitcoin regtest network. It's possible with Makefile script. You can find more info in our docs

fahimahmedx commented 2 years ago

@xyzmaker123 Thank you for the guidance, am very new to open-source development so I appreciate it!

Currently I'm looking at the docs for https://github.com/bisq-network/bisq/tree/master/docs/autosetup-regtest-dao

It seems like this would cause a test transaction to occur. However what I'm confused about is how I would get this to show up on the front-end, which I'm testing?

fahimahmedx commented 2 years ago

I think I'm starting to get a better understanding. Seems like 50 btc is filled to the test wallet after generating a few blocks.

https://github.com/bisq-network/bisq/blob/master/docs/dev-setup.md In this setup, it mentions to run four different bisq programs each with different arguments. Is this neccesary to test the "Open Trades" page?

ghost commented 2 years ago

@fahimahmedx You're welcome. Everything described in dev-setup.md is covered inside Makefile. You just run make deploy and you'll get Bob&Alice app instances up and running.

fahimahmedx commented 2 years ago

I added some columns and am happy to see the data in testnet works! However, the "Export CSV" button I added in PendingTradesView.fxm is being overridden with the menu containing "Trade process" and "Trade information". As a result, I was thinking of adding it to the .fxm of this bottom portion of the menu if the file exists, and was wondering if you know how I'd go about doing that? Have not been able to find the file yet, so am confused where the front-end for this portion below the table is setup.

fahimahmedx commented 2 years ago

want to follow up on this. Was able to get the export button to show when this overlay doesn't show, but am still stuck.