search

bisq-network / bisq

A decentralized bitcoin exchange network
https://bisq.network
GNU Affero General Public License v3.0
4.68k stars 1.26k forks source link

[1.7.0] DAO gets out of sync once or twice a day #5595

Open Akira45-0 opened 3 years ago

Akira45-0 commented 3 years ago

Description

Since the update to 1.7.0 I needed to make DAO resync four times, which means that the DAO needs to be resynced once or twice a day.

I am using Bisq on Windows 10 as a full DAO node.

Version

1.7.0

Steps to reproduce

Just use Bisq. Sooner or later it will ask you to shut down and resync the DAO.

Expected behaviour

DAO should remain synced.

Actual behaviour

DAO gets out of sync.

Screenshots

Device or machine

Windows 10.

Additional info

tsjk commented 3 years ago

Yes, I've stumbled upon this as well. Twice within 6 hours or so. My operating system is Linux.

ripcurlx commented 3 years ago

I got it myself a couple of times already as well. Looking into it.

jkuchar commented 3 years ago

Also affected. Directly after resync I get message that DAO is out of sync. It looks like there is 100% conflicts with other nodes. It looks like my node is missing any peers consensus after block 689 196. Conflicts starts after block 690 300.

When I open "Network monitor" I get message:

 Your local data is not in consensus with at least one seed node. Please resync the DAO state.

ddawson commented 2 years ago

Having the same thing happening in 1.8.0, on Linux. Not a full node. If it helps, I'm running my own Bitcoin node and an external (to Bisq) Tor daemon.

ripcurlx commented 2 years ago

We do have a seednode that is out of sync ATM which is filtered out, but you need to restart your client once to be able to apply this filter also on startup.

ddawson commented 2 years ago

Do you mean the filter is applied automatically? Because I've restarted the client quite a few times, and this keeps happening.

ripcurlx commented 2 years ago

Do you mean the filter is applied automatically? Because I've restarted the client quite a few times, and this keeps happening.

🤔 Can you please check the DAO network monitor and let me know with which seednodes you have a conflict with.

ddawson commented 2 years ago

Can you please check the DAO network monitor and let me know with which seednodes you have a conflict with.

None at the moment:

One of your peers is not in consensus with the network but your node is in sync with the seed nodes.

That is part of what I have been observing. I'll keep an eye on it to see if the other part (saying it needs to be resynced) happens again.

ddawson commented 2 years ago

It happened again. It won't tell me which node(s), or at least I don't know how to get that info. (Could it be because "Full-mode DAO state monitoring" is off?) It just says, "Your local data is not in consensus with at least one seed node. Please resync the DAO state."

It may be worth noting, however, under "Chain of DAO state hashes", even when it doesn't show a conflict with seed nodes, there are many blocks showing conflicts. At this point, the last 283 blocks (718061–718343) have anywhere from 2 to 13 conflicts each. Hash creator is "self" for all of them, while for those without conflicts (except the last), it's "peer". It appears as though it's building up conflicts with peers, until eventually it conflicts with a seed.

golyalpha commented 2 years ago

I have a fresh install of Bisq 1.8.0 on Linux (Fedora 35), this is happening consistently every time I start it (even after requesting the resync) I have conflicts with all the nodes listed. image

golyalpha commented 2 years ago

Whatever the issue was, after updaing to v1.8.2 and doing a DAO resync this appears to no longer be an issue for me.

snex commented 7 months ago

v1.9.14, this has started happening to me recently. On Settings > Network Info, I see data being sent and received but it seems extremely slow. Eventually the app just gives up and says I'm out of sync.

bitdisturber commented 6 months ago

Ditto here. v1.9.14, Win 11, message to resync every few hours, has been happening for weeks (coudn't say whether it would have been an issue prior to v1.9.14 as I was away for an extended period and restarted at v1.9.14).

alecov commented 3 months ago

Twice a day? More like, five times per ten minutes, amirite?

It is so annoying I can restart the client five times in a row and it will almost surely and immediately complain about it at the sixth time. This is completely bogus, since this DAO thing doesn't seem to affect trading at all, but the nagging never ever ever stops.

Assuming it doesn't affect trading, the real fix would be: it should be completely optional for the client to sync the DAO state. I don't care about it, specially if the client won't stop nagging about it. In this case, regardless of any sync issue the client should never popup on your face, or at the very least have a checkbox "Do not show me this ever again".

pazza83 commented 1 month ago

Syncing the DAO is needed for the creation of the delayed payout transactions.

For this reason clients always need to be in sync with the DAO. The DAO sync has been a lot more stable recently. Is this still an issue?

Akira45-0 commented 1 month ago

For me it works fine now, thank you.