search

bisq-network / bisq

A decentralized bitcoin exchange network
https://bisq.network
GNU Affero General Public License v3.0
4.73k stars 1.27k forks source link

Error when taking offer #6414

Closed CatsDans closed 1 year ago

CatsDans commented 2 years ago

Bisq v1.9.6

When you click the "next" button on the "take offer" page, a message appears: "Warning This offer is not valid. Please choose a different offer. [Maker tx validation]"

Whonix v16.0.8.2

Sometimes it is possible to accept a deal, but in most cases an error appears. About 2 months ago, everything worked without problems.

ghost commented 2 years ago

@CatsDans could you attach your bisq.log file covering the time when the problem happens?

If specific to an offer or group of offers, could you paste the offer IDs here?

CatsDans commented 2 years ago

@CatsDans could you attach your bisq.log file covering the time when the problem happens?

If specific to an offer or group of offers, could you paste the offer IDs here?

Yes, of course. Moreover, I have already made a deal with each of these users before. That was about a few months ago.

Offers IDs, which I tried. 7a16P8-41a930ad-dfd3-4d52-9e40-ee6443732503-196 NCJ3EWBR-0d1d7c4c-451b-40da-98fe-78a73399aa75-195


Nov-16 16:45:08.127 [JavaFX Application Thread] INFO  b.n.p.p.PeerManager: We have not exceeded outBoundPeerTrigger of 16 so don't need to close any connections 
Nov-16 16:45:30.657 [BlockingClient network thread for devinbtctu7uctl7hly2juu3thbgeivfnvw3ckj3phy6nyvpnx66yeyd.onion/<unresolved>:8333] INFO  o.b.core.Peer: Peer{[devinbtctu7uctl7hly2juu3thbgeivfnvw3ckj3phy6nyvpnx66yeyd.onion]:8333, version=70016, subVer=/Satoshi:0.21.1(@devinbileck)/, services=1037 (NETWORK, BLOOM, WITNESS, NETWORK_LIMITED), time=2022-11-16 16:38:47, height=763447}: Announced fee filter: 0.00004924 BTC/kB 
Nov-16 16:45:31.339 [JavaFX Application Thread] INFO  b.c.b.m.AddressEntryList: swapAvailableToAddressEntryWithOfferId newAddressEntry=AddressEntry{address=bc1qytltucy2uny2f3c0c0g7lj3zymdjyxqgw2a8u4, context=OFFER_FUNDING, offerId='7a16P8-41a930ad-dfd3-4d52-9e40-ee6443732503-196', coinLockedInMultiSig=0, segwit=true} 
Nov-16 16:45:31.355 [JavaFX Application Thread] INFO  b.d.m.o.b.t.TakeOfferDataModel: Start requestTxFee: txFeeFromFeeService=4452 
Nov-16 16:45:31.363 [MempoolRequest @ http://mempool4t6mypeemozyterviq3i5de4kpoua65r3qkn5i3kknu5l2cad.onion/api/tx] INFO  b.c.p.m.MempoolRequest: Making http request for information on txId: fd033b963a9ed960f4fa40d58f8854227ce268cf7a4c367c809c5758463d402b 
Nov-16 16:45:31.378 [JavaFX Application Thread] INFO  b.c.t.TaskRunner: Run task: SendOfferAvailabilityRequest 
Nov-16 16:45:31.387 [JavaFX Application Thread] INFO  b.c.o.a.t.SendOfferAvailabilityRequest: Send OfferAvailabilityRequest with offerId 7a16P8-41a930ad-dfd3-4d52-9e40-ee6443732503-196 and uid 988ec2e9-dbbd-423d-bc95-8bc686dc3de2 to peer f645t3vxxvvkpg2dvtgxhwwtshz4uvz36t3ipr4frwxw6s2gzopdobyd.onion:9999 
Nov-16 16:45:31.409 [NetworkNode:SendMessage-to-f645t3vxxvvkpg2dvtgxhwwtshz4uvz36t3ipr4frwxw6s2gzopdobyd.onion:9999] DEBUG o.b.n.tor.Tor: trying to connect to f645t3vxxvvkpg2dvtgxhwwtshz4uvz36t3ipr4frwxw6s2gzopdobyd.onion:9999 
Nov-16 16:45:31.410 [NetworkNode:SendMessage-to-f645t3vxxvvkpg2dvtgxhwwtshz4uvz36t3ipr4frwxw6s2gzopdobyd.onion:9999] DEBUG o.b.n.tor.Tor: got proxy localhost:9150  Version 5 
Nov-16 16:45:34.029 [JavaFX Application Thread] INFO  b.c.p.f.FeeService: BTC tx fee: txFeePerVbyte=18 minFeePerVbyte=3 
Nov-16 16:45:34.030 [JavaFX Application Thread] INFO  b.d.m.o.b.t.TakeOfferDataModel: Completed requestTxFee: txFeeFromFeeService=3816 
Nov-16 16:45:49.620 [NetworkNode:SendMessage-to-n2wbpjtfwjtb7gf2yeg67r5mzuvpebzbaimbpjzlwprg2dht3r5gciyd.onion:9999] DEBUG o.b.n.tor.Tor: Took 133158ms to connect to n2wbpjtfwjtb7gf2yeg67r5mzuvpebzbaimbpjzlwprg2dht3r5gciyd.onion:9999 
Nov-16 16:45:49.620 [NetworkNode:SendMessage-to-n2wbpjtfwjtb7gf2yeg67r5mzuvpebzbaimbpjzlwprg2dht3r5gciyd.onion:9999] INFO  b.n.p.n.NetworkNode: Socket creation to peersNodeAddress n2wbpjtfwjtb7gf2yeg67r5mzuvpebzbaimbpjzlwprg2dht3r5gciyd.onion:9999 took 133158 ms 
Nov-16 16:46:02.079 [InputHandler-devinv3rhon24gqf5v6ondoqgyrbzyqihzyouzv7ptltsewhfmox2zqd.onion:8000] INFO  b.n.p.n.Connection: Connection shutdown started 
Nov-16 16:46:02.080 [JavaFX Application Thread] INFO  b.n.p.p.PeerManager: onDisconnect called: nodeAddress=Optional[devinv3rhon24gqf5v6ondoqgyrbzyqihzyouzv7ptltsewhfmox2zqd.onion:8000], closeConnectionReason=CloseConnectionReason{sendCloseMessage=false, isIntended=true} CLOSE_REQUESTED_BY_PEER 
Nov-16 16:46:02.080 [JavaFX Application Thread] INFO  b.n.p.p.p.PeerExchangeManager: onDisconnect closeConnectionReason=CloseConnectionReason{sendCloseMessage=false, isIntended=true} CLOSE_REQUESTED_BY_PEER, nodeAddressOpt=Optional[devinv3rhon24gqf5v6ondoqgyrbzyqihzyouzv7ptltsewhfmox2zqd.onion:8000] 
Nov-16 16:46:06.687 [NetworkNode:SendMessage-to-f645t3vxxvvkpg2dvtgxhwwtshz4uvz36t3ipr4frwxw6s2gzopdobyd.onion:9999] DEBUG o.b.n.tor.Tor: Took 35278ms to connect to f645t3vxxvvkpg2dvtgxhwwtshz4uvz36t3ipr4frwxw6s2gzopdobyd.onion:9999 
Nov-16 16:46:06.688 [NetworkNode:SendMessage-to-f645t3vxxvvkpg2dvtgxhwwtshz4uvz36t3ipr4frwxw6s2gzopdobyd.onion:9999] INFO  b.n.p.n.NetworkNode: Socket creation to peersNodeAddress f645t3vxxvvkpg2dvtgxhwwtshz4uvz36t3ipr4frwxw6s2gzopdobyd.onion:9999 took 35279 ms 
Nov-16 16:46:06.691 [JavaFX Application Thread] INFO  b.n.p.p.PeerManager: Num of latestLivePeers=11 
Nov-16 16:46:06.692 [JavaFX Application Thread] INFO  b.c.o.a.t.SendOfferAvailabilityRequest: OfferAvailabilityRequest arrived at peer: offerId=7a16P8-41a930ad-dfd3-4d52-9e40-ee6443732503-196; uid=988ec2e9-dbbd-423d-bc95-8bc686dc3de2 
Nov-16 16:46:09.052 [JavaFX Application Thread] INFO  b.c.o.a.OfferAvailabilityProtocol: Received handleOfferAvailabilityResponse from f645t3vxxvvkpg2dvtgxhwwtshz4uvz36t3ipr4frwxw6s2gzopdobyd.onion:9999 with offerId 7a16P8-41a930ad-dfd3-4d52-9e40-ee6443732503-196 and uid 5fc55c8f-795e-490c-ae8c-998f78c108b1 
Nov-16 16:46:09.053 [JavaFX Application Thread] INFO  b.c.t.TaskRunner: Run task: ProcessOfferAvailabilityResponse 
Nov-16 16:46:09.053 [JavaFX Application Thread] INFO  b.c.o.a.OfferAvailabilityProtocol: Send AckMessage for OfferAvailabilityResponse to peer f645t3vxxvvkpg2dvtgxhwwtshz4uvz36t3ipr4frwxw6s2gzopdobyd.onion:9999 with offerId 7a16P8-41a930ad-dfd3-4d52-9e40-ee6443732503-196 and sourceUid 5fc55c8f-795e-490c-ae8c-998f78c108b1 
Nov-16 16:46:09.057 [JavaFX Application Thread] INFO  b.c.o.a.OfferAvailabilityProtocol: AckMessage for OfferAvailabilityResponse arrived at makersNodeAddress f645t3vxxvvkpg2dvtgxhwwtshz4uvz36t3ipr4frwxw6s2gzopdobyd.onion:9999. offerId=7a16P8-41a930ad-dfd3-4d52-9e40-ee6443732503-196, sourceUid=5fc55c8f-795e-490c-ae8c-998f78c108b1 
Nov-16 16:46:09.135 [JavaFX Application Thread] INFO  b.c.o.OpenOfferManager: Received AckMessage for OfferAvailabilityRequest with offerId 7a16P8-41a930ad-dfd3-4d52-9e40-ee6443732503-196 and uid 988ec2e9-dbbd-423d-bc95-8bc686dc3de2 
Nov-16 16:46:09.538 [JavaFX Application Thread] INFO  b.n.p.n.ConnectionState: We have changed the peerType from INITIAL_DATA_EXCHANGE to PEER as we have received all expected initial data responses at connection with peer Optional[sn3emzy56u3mxzsr4geysc52feoq5qt7ja56km6gygwnszkshunn2sid.onion:8000]/ad967596-656d-468c-8e7f-83dba9a24267. 
Nov-16 16:46:16.702 [JavaFX Application Thread] INFO  b.n.p.p.PeerManager: We have 13 connections open. Our limit is 12 
Nov-16 16:46:16.702 [JavaFX Application Thread] INFO  b.n.p.p.PeerManager: We have too many connections open. Lets try first to remove the inbound connections of type PEER. 
Nov-16 16:46:16.702 [JavaFX Application Thread] INFO  b.n.p.p.PeerManager: No candidates found. We check if we exceed our outBoundPeerTrigger of 16 
Nov-16 16:46:16.702 [JavaFX Application Thread] INFO  b.n.p.p.PeerManager: We have not exceeded outBoundPeerTrigger of 16 so don't need to close any connections 
Nov-16 16:46:51.683 [MempoolRequest @ http://mempool4t6mypeemozyterviq3i5de4kpoua65r3qkn5i3kknu5l2cad.onion/api/tx] INFO  b.c.p.m.MempoolRequest: Received mempoolData of [{"txid":"fd033b963a9ed960f4fa40d58f8854227ce268cf7a4c367c809c5758463d402b","version":1,"locktime":0,"vin":[{"txid":"99f62449895329de13351b24e607359b79e0a0dc90aa45814580a7b1d3bc6bb3","vout":0,"prevout":{"scriptpubkey":"00148603efa225795544540300c82871dd434f46f9d9","scriptpubkey_asm":"OP_0 OP_PUSHBYTES_20 8603efa225795544540300c82871dd434f46f9d9","scriptpubkey_type":"v0_p2wpkh","scriptpubkey_address":"bc1qscp7lg390925g4qrqryzsuwagd85d7we6cq7ut","value":1570104},"scriptsig":"","scriptsig_asm":"","witness":["304402205872724ee3d0db76a623d0c181dec084119f0108418c810b6fdce3036461a34302207f1f9c7043e8861b9e84df49c878667082894649ea7d9ba7aa32a4a20ac4647901","032b4735bad1e3652fcc80670a987e303db74c4970282d5111130179ece757621e"],"is_coinbase":false,"sequence":4294967295},{"txid":"0dc1acbf1d5246a01863f40516c63f8f450e406f4ca7fa46d9fb46e7c8377491","vout":0,"prevout":{"scriptpubkey":"00149ddcd1c3cb4e149cbdd58460fac09fcfd7bec6ca","scriptpubkey_asm":"OP_0 OP_PUSHBYTES_20 9ddcd1c3cb4e149cbdd58460fac09fcfd7bec6ca","scriptpubkey_type":"v0_p2wpkh","scriptpubkey_address":"bc1qnhwdrs7tfc2fe0w4s3s04syleltma3k26u2g0f","value":1265000},"scriptsig":"","scriptsig_asm":"","witness":["3044022048291282b69c154631b46101110b51f8badc1e758f7f28601d709c849993529b0220718531f41d0bfb3bbccad9588de04f8ad84bbc125b3c3bcf803c5581082bdea201","03c1117c7ef7816d4d60760d4b2b702f83b315e40143f9ed5dbdd91f84f444fab3"],"is_coinbase":false,"sequence":4294967295}],"vout":[{"scriptpubkey":"0014032efaa1a3e280e63cd234cf882d12702263b965","scriptpubkey_asm":"OP_0 OP_PUSHBYTES_20 032efaa1a3e280e63cd234cf882d12702263b965","scriptpubkey_type":"v0_p2wpkh","scriptpubkey_address":"bc1qqvh04gdru2qwv0xjxn8cstgjwq3x8wt968vmt7","value":1570033},{"scriptpubkey":"001473025736d5788c01ef4e0644251e65a4ce2f5f68","scriptpubkey_asm":"OP_0 OP_PUSHBYTES_20 73025736d5788c01ef4e0644251e65a4ce2f5f68","scriptpubkey_type":"v0_p2wpkh","scriptpubkey_address":"bc1qwvp9wdk40zxqrm6wqezz28n95n8z7hmg2v0xkj","value":750000},{"scriptpubkey":"00141b93421c382601e575afd7083a9a771672526cf8","scriptpubkey_asm":"OP_0 OP_PUSHBYTES_20 1b93421c382601e575afd7083a9a771672526cf8","scriptpubkey_type":"v0_p2wpkh","scriptpubkey_address":"bc1qrwf5y8pcycq72ad06uyr4xnhzee9ym8cwfwkmv","value":511151}],"size":401,"weight":956,"fee":3920,"status":{"confirmed":true,"block_height":763426,"block_hash":"0000000000000000000602884dc73277fdc745df646f7fa314b013ff4b9eb8c3","block_time":1668604002}}] from provider 
Nov-16 16:46:51.690 [JavaFX Application Thread] ERROR b.c.p.m.TxValidator: The apparent BSQ fee burnt seems ridiculously high (71) compared to expected (3) 
Nov-16 16:46:51.691 [JavaFX Application Thread] ERROR b.c.p.m.TxValidator: Could not obtain the burnt BSQ amount, trade will be flagged for manual review. 
Nov-16 16:46:51.693 [JavaFX Application Thread] WARN  b.c.p.m.TxValidator: Fee does not match fee from filter. Fee from filter=1421. Expected fee: 0.03 BSQ, actual fee paid: 0.00 BSQ 
Nov-16 16:46:51.706 [JavaFX Application Thread] INFO  b.c.p.m.TxValidator: Maker tx validation : FAIL 
Nov-16 16:46:51.710 [JavaFX Application Thread] INFO  b.d.m.o.b.t.TakeOfferDataModel: Mempool check of OfferFeePaymentTxId returned errors: [[Maker tx validation]] 
Nov-16 16:46:56.100 [JavaFX Application Thread] INFO  b.c.b.w.BtcWalletService: resetAddressEntriesForOpenOffer offerId=7a16P8-41a930ad-dfd3-4d52-9e40-ee6443732503-196 
Nov-16 16:46:56.100 [JavaFX Application Thread] INFO  b.c.b.w.BtcWalletService: swap addressEntry with address bc1qytltucy2uny2f3c0c0g7lj3zymdjyxqgw2a8u4 and offerId 7a16P8-41a930ad-dfd3-4d52-9e40-ee6443732503-196 from context OFFER_FUNDING to available 
Nov-16 16:46:56.100 [JavaFX Application Thread] INFO  b.c.b.m.AddressEntryList: swapToAvailable addressEntry to swap=AddressEntry{address=bc1qytltucy2uny2f3c0c0g7lj3zymdjyxqgw2a8u4, context=OFFER_FUNDING, offerId='7a16P8-41a930ad-dfd3-4d52-9e40-ee6443732503-196', coinLockedInMultiSig=0, segwit=true} 
Nov-16 16:46:56.100 [JavaFX Application Thread] INFO  b.c.b.w.BtcWalletService: resetAddressEntriesForOpenOffer offerId=7a16P8-41a930ad-dfd3-4d52-9e40-ee6443732503-196 
Nov-16 16:46:58.519 [JavaFX Application Thread] INFO  b.c.p.PersistenceManager: Serializing SignedWitnessStore took 157 msec 
Nov-16 16:46:58.537 [Write-TradeStatistics3Store_to-disk] INFO  b.c.p.PersistenceManager: Writing the serialized TradeStatistics3Store completed in 168 msec 
Nov-16 16:46:58.826 [Write-SignedWitnessStore_to-disk] INFO  b.c.p.PersistenceManager: Writing the serialized SignedWitnessStore completed in 307 msec
ghost commented 2 years ago

@CatsDans do you have the Bisq DAO disabled? (DAO menu).

Its the only thing I can think of which would make it misinterpret the maker fee that way.

Ideal solution would be to enable the DAO.

CatsDans commented 1 year ago

@jmacxx Yes, you're right! Thanks for the advice! If you turn on the DAO, then everything really started working fine. It is strange that for 2-3 years I have not had any problems with this and only now there are problems...