search

bisq-network / bisq

A decentralized bitcoin exchange network
https://bisq.network
GNU Affero General Public License v3.0
4.73k stars 1.27k forks source link

Market Depth (order book) graph shows inverted colors #6639

Closed christian-hawk closed 1 year ago

christian-hawk commented 1 year ago

Description

Market Depth shows GREEN for sell offers and RED for buy offers, the correct is the opposite. Market Depth (order book) graph shows inverted colors. This is very confusing for who uses the graph (traders).

image

Version

v1.9.9

Steps to reproduce

  1. Open app
  2. Click on Market
  3. Check Order Book tab

Expected behaviour

Should show RED for selling offers and GREEN for buying offers. As you can see in any other platform that provides the market depth:

image

Device or machine

Mac OS

boring-cyborg[bot] commented 1 year ago

Thanks for opening your first issue here!

Be sure to follow the issue template. Your issue will be reviewed by a maintainer and labeled for further action.

pazza83 commented 1 year ago

This has been discussed previously:

https://github.com/bisq-network/bisq/issues/2383

I think it is ok the way it is now.

Green = Buy Red = Sell

helixx87 commented 1 year ago

I see that #2383 discussion wasn't finished but marked as stale by bot.

Green = Buy Red = Sell

It's a bit more complex - when you buy you take someone's sell offer and vice versa. It seems to be standard in the trading world that someone's buy offers are marked green on market depth chart.

Consider Binance trading view: binance-market-depth

I think in addition to what I've done in my PR we could also:

christian-hawk commented 1 year ago

This has been discussed previously:

2383

I think it is ok the way it is now.

Green = Buy Red = Sell

@pazza83 allow me to disagree that it may be ok being wrong. It's an important trading tool, and it should be done right. High volume traders starting in Bisq use this tool a lot :)

It would be the same as having red candle when prices moves up and green when prices moves down in candlestick price graph. That would also not be ok at all for traders.

I see that #2383 discussion wasn't finished but marked as stale by bot.

Green = Buy Red = Sell

It's a bit more complex - when you buy you take someone's sell offer and vice versa. It seems to be standard in the trading world that someone's buy offers are marked green on market depth chart.

I think in addition to what I've done in my PR we could also:

  • inverse buttons (green BUY BTC will be on the left side above buy offers and vice versa)
  • remove headline Sell BTC to or rename it to Buy offers

Indeed @helixx87 . Btw thank you for the PR.

Actually is not that complex.

Rule is:

What we call OFFER is a maker order that is similar to a Limit Order with some extra features such as % deviation.

When I take an order (aka offer) I'm the market taker. I also submit an order to accept the open order. (i.e. market order). So, when I submit a BUY (green) taker order from a SELL (red) maker order I usually do that in a green button.

If I want to buy at certain price, I will look for the red prices in order book, and red block in market depth graph.

About adding other changes to the PR:

  1. notice that the scope of this issue is regarding the Market Depth Graph only.

  2. Fixing the order book sides is another issue (with lower impact, from my perspective, but still important). It may be placed in another independent issue.

  3. EDITED Buttons may be anywhere, as long as BUY is GREEN and SELL is RED.

Additional context:

Order book sides - Green (buy orders) on left, Red (sell orders) on right

image
pazza83 commented 1 year ago

Many tanks for the comments @christian-hawk

Everything you say makes sense.

About adding other changes to the PR:

  1. notice that the scope of this issue is regarding the Market Depth Graph only.
  2. Fixing the order book sides is another issue (with lower impact, from my perspective, but still important). It may be placed in another independent issue.
  3. Buttons may be anywhere, as long as BUY is RED and SELL is RED.

Would it be possible for you to mockup or sketch out what you think is the best way for the offer book to be presented? I think if changes are to be made they might as well all be made at once.

christian-hawk commented 1 year ago

Many tanks for the comments @christian-hawk

Everything you say makes sense.

About adding other changes to the PR:

  1. notice that the scope of this issue is regarding the Market Depth Graph only.
  2. Fixing the order book sides is another issue (with lower impact, from my perspective, but still important). It may be placed in another independent issue.
  3. Buttons may be anywhere, as long as BUY is RED and SELL is RED.

Would it be possible for you to mockup or sketch out what you think is the best way for the offer book to be presented? I think if changes are to be made they might as well all be made at once.

I'm really a backend guy, but I can try. Any tools you may suggest for doing it @pazza83 ?

pazza83 commented 1 year ago

Gimp comes recommenced but might be more powerful than you need.

It does not have to be fancy, I suppose just something that shows what you think would be best in image form.

helixx87 commented 1 year ago

Hi @pazza83, in response to your request I'm attaching a recording with a demo of the changes currently included in the pull request:

https://github.com/bisq-network/bisq/assets/128257662/38f97275-e808-4a01-a2f4-0e7ef36b71fb

pazza83 commented 1 year ago

Hi @helixx87

Thanks for posting the video.

I'm confused by this.

In the offers shown on the main screen (showing both buy and sell offers), when clicking on sell you see the buy offers, and when clicking on buy you see the sell offers.

Not sure if this is how it would be in practice? Assuming not.

helixx87 commented 1 year ago

Thanks @pazza83, you're right - I fixed this issue in the newest commit. Here is a updated demo:

https://github.com/bisq-network/bisq/assets/128257662/16567f0c-229c-40f0-9795-fe3869fb8238

pazza83 commented 1 year ago

Thanks, I am still confused:

Your demo:

Capture2

My Bisq:

Capture

I can see the colors are inverted, but surely the offer books should also be inverted?

Something more like this (once red and green have been inverted):

Capture3

helixx87 commented 1 year ago

OK, I prepared diagram that should help us with making final decision how it should works

areas

I propose for now focus on BTC/Fiat market - current implementation on PR works like that:

A) Left side:

B) Right side:

I agree this behavior is a bit confusing - I'm looking forward to some proposals how to improve it. I'll also think about it and try to propose something.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 1 year ago

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.