search

bisq-network / bisq

A decentralized bitcoin exchange network
https://bisq.network
GNU Affero General Public License v3.0
4.65k stars 1.26k forks source link

Honor Freedesktop XDG base spec #6933

Open gerardbosch opened 8 months ago

gerardbosch commented 8 months ago

Description

The Freedesktop XDG base spec seems not to be totally honored. I explain myself:

Just after installing and running of Bisq for the first time, I noticed that the ~/.local/share/Bisq/ directory took 568 MB. This is specially important because I'm doing an automated cloud backup of my homedir on daily basis, based on XDG spec to only backup user files. So I had to add an exclusion to my backup for this directory after realizing of this, to avoid incurring on extra or unnecessary backup cost.

The XDG_DATA_HOME should be for user data, but the initial 568 MB are from the Bitcoin network. In essence, this seems not to be user data, but data that can be recreated.

From https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html

$XDG_CACHE_HOME defines the base directory relative to which user-specific non-essential data files should be stored. If $XDG_CACHE_HOME is either not set or empty, a default equal to $HOME/.cache should be used.

$XDG_DATA_HOME defines the base directory relative to which user-specific data files should be stored. If $XDG_DATA_HOME is either not set or empty, a default equal to $HOME/.local/share should be used.

So I think that the XDG_CACHE_HOME dir would be more appropriate for the Bitcoin database, Tor, and/or other non-user data that can be fetched or recreated than the currently used XDG_DATA_HOME.

image

Version

1.9.14

Steps to reproduce

Install Bisq from the official DEB and run it for the first time.

Expected behaviour

The XDG_DATA_HOME would contain user-specific data.

Actual behaviour

The XDG_DATA_HOME contains more than 500 MB of that that is not user-specific and can be recreated.

Screenshots

n/a

Device or machine

Linux

Additional info

n/a

boring-cyborg[bot] commented 8 months ago

Thanks for opening your first issue here!

Be sure to follow the issue template. Your issue will be reviewed by a maintainer and labeled for further action.

github-actions[bot] commented 5 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

gerardbosch commented 5 months ago

no-stale

github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

gerardbosch commented 2 months ago

no-stale

Waiting for triage.