bisq-network / bisq

A decentralized bitcoin exchange network
https://bisq.network
GNU Affero General Public License v3.0
4.63k stars 1.26k forks source link

150 threads blocked on same peer? #7140

Open lordbah opened 4 weeks ago

lordbah commented 4 weeks ago

Description

NOTE: I might be mistaken about this. It might be nothing. I don't know enough to say. Log makes me suspect the app gets into a state where it has dozens of PeerGroup threads blocked on the same peer. That might lead to hammering that peer when it becomes reachable again, or wasted effort processing the same blocks multiple times when reading the same blocks on multiple threads.

Version

1.9.15

Steps to reproduce

I just run bisq. It may be that one or more peers being unreachable is necessary.

Expected behaviour

Actual behaviour

Screenshots

Device or machine

PopOS 22.04 LTS (Ubuntu Linux)

Additional info

Jun-04 09:50:25.913 [PeerGroup Thread] INFO o.b.c.PeerGroup: Waiting 452745 ms before next connect attempt to [emzybtc25oddoa2prol2znpz2axnrg6k77xwgirmhv7igoiucddsxiad.onion]:8333 Jun-04 09:50:25.913 [PeerGroup Thread] INFO o.b.c.PeerGroup: Waiting 452745 ms before next connect attempt to [emzybtc25oddoa2prol2znpz2axnrg6k77xwgirmhv7igoiucddsxiad.onion]:8333 Jun-04 09:50:25.913 [PeerGroup Thread] INFO o.b.c.PeerGroup: Waiting 452745 ms before next connect attempt to [emzybtc25oddoa2prol2znpz2axnrg6k77xwgirmhv7igoiucddsxiad.onion]:8333 ... This seems like 150 threads all logging the same thing within the same second. b.log