Open unbeaten69 opened 1 month ago
It's probably not worth changing the code as when it's done, mining fees could go over 10sat/vb. But I agree that this measure is not as effective as we think when mining fees skyrocket, while in this rare situations where mining fees are lower than 10 sats/vb, it is wasteful.
One has to consider the time delay between the take offer event and the publishing of the payout tx. The miner fee for the payout tx is defined at take offer time. In case the miner fee is very low at take offer time but rises much higher during the trade period (which can be 1 week in slow fiat payment methods or mediation disputes) there is risk that the payout tx never gets confirmed which causes extra effort to use a manual payout tx. Dealing with miner fees is a pain and there is not perfect solution. But I think the problems with stuck transactions are much worse then the overpay in low-fee environments. As I guess we did not had much issues with stuck transactions even in the past month with crazy miner fee volatility, I think the current model is in a good shape and should not be changed without proper analysis and reason.
It has been over a month since this issue was opened and fees are still well below 10 sat/vB. It would not have been wasteful to change the code a month ago and it would not be wasteful to change it now. When fees are over 10, competitive rates are chosen by the app. There is zero reason to not choose competitive rates when fees are below 10. Whatever problems in fee spikes you list have been around forever and will be around when fees are above 10.
Description
Transaction fee used by Bisq for trading never seems to go below 10 sat/vB, even when less than half of that easily gets you into the top block...
curl -s --proxy socks5h://127.0.0.1:9050 http://devinpndvdwll4wiqcyq5e7itezmarg7rzicrvf6brzkwxdm374kmmyd.onion/getAllMarketPrices | jq ".bitcoinFeeInfo"
I understand that it probably was implemented this was to save users problems when fees spike, but doesn't that problem come back anyway whenever fees hover above 10 sat/vB for a longer period of time?