search

bisq-network / bisq2

GNU Affero General Public License v3.0
167 stars 62 forks source link

Stop Bisq Easy switching profiles to earliest created profile when in 'Bisq Easy' menu #1458

Open darawhelan opened 9 months ago

darawhelan commented 9 months ago

When you have a profile selected and go to the 'Bisq Easy' section your profile switches to what seems to be the most recent profile that did an action.

dara

Ignore the poor image quality, it is just the gif compression.

Instead the profile selected should remain selected when going to the Bisq Easy section

HenrikJannsen commented 9 months ago

The idea is to avoid that users accidentally leak their identities by using the wrong profile. So if you once have posted with User1 and then switch wherever to User2 and go back to the chat where you posted with User1 it will switch to User1. If you manually switch to User2 and post another message you get a warning.

But I understand that this might be confusing. Maybe we do not switch user and only use the warning.

But similarly when the user goes to a trade or private chat the user profile switches to the user for that channel (and does not allow switching the user). Actually there is a bug that it does not switch the user, but should do.

What would you suggest?

darawhelan commented 9 months ago

Yes, I saw the warning I think that is good.

I think forcing the switch seems wrong to do, and makes it more likely the user will make an error.

I would suggest keeping the current profile selected. This would require the user to manually change the profile themselves. I think this is better UI and give the user more control over their profile selection.