bisq-network / bisq2

GNU Affero General Public License v3.0
197 stars 69 forks source link

Disabling `Use animations` setting needs to ensure no animations/transitions are used #1878

Open devinbileck opened 8 months ago

devinbileck commented 8 months ago

Summary

As discovered in #1857, if hardware acceleration is not enabled then the UI may suffer from poor performance.

If not automatically detected, hardware acceleration can be force enabled with -Dprism.forceGPU=true. However, this will not be a viable workaround for systems that do not have hardware acceleration such as virtual machines.

As I discovered while investigating #1857, commenting out various animations such as timeline.play() improved the performance.

Currently disabling Use animations under Settings > Display settings does not help. Disabling this needs to ensure no animations/transitions are used at all. Optionally, the app could detect whether hardware acceleration is in use and disable the Use animations setting automatically.

Acceptance Criteria

HenrikJannsen commented 3 months ago

It should be deactivated everywhere if the use animations flag in the preferences is turned off. Have you tried that and found still some animations? Might have been forgotten to check at some animations.

devinbileck commented 3 months ago

It should be deactivated everywhere if the use animations flag in the preferences is turned off. Have you tried that and found still some animations? Might have been forgotten to check at some animations.

No, I did not do any further investigation to find specific animations. If someone has some time, would be good to revisit and investigate this.