bisq-network / bisq2

GNU Affero General Public License v3.0
140 stars 53 forks source link

During trade process, also show resulting price and premium #1889

Open suddenwhipvapor opened 3 months ago

suddenwhipvapor commented 3 months ago

If as a buyer I make an offer, I will get seller takers offering to sell to me at their x% over market price. Currently, there is no way to select, during offer creation, the maximum premium I am willing to pay (and make it hidden preferably, otherwise all sellers will just aim at that value... I think I will open another issue for this), but I will just see the btc equivalent for the fiat I want to spend.

So I think the trade panel should also show, other than "amount to pay" and "amount to receive", two additional fields, namely "btc price" and "deviation %" so the buyer can more easily assess the deal.

HenrikJannsen commented 3 months ago

The price is in the table where other trade data are listed. We could add the premium as tooltip to the price or make the column toggle-able to show either price as number or price as % above market price (at take offer time).

The selected price pane should not get overloaded so adding the price here would require removing other data. As price and the 2 amounts are redundant I think hiding price is the best option.

@axpoems What do you think?

HenrikJannsen commented 3 months ago

Related to https://github.com/bisq-network/bisq2/issues/1949