kciouv
commented
1 week ago ACK / Nit:
Technically, the Tor log does contain something sensitive (user's name, if their user account is named after themselves).
Closed HenrikJannsen closed 1 week ago
kciouv
commented
1 week ago ACK / Nit:
Technically, the Tor log does contain something sensitive (user's name, if their user account is named after themselves).
HenrikJannsen
commented
1 week ago ACK / Nit:
Technically, the Tor log does contain something sensitive (user's name, if their user account is named after themselves).
Fixed with https://github.com/bisq-network/bisq2/pull/2334/commits/7ebc9e9de84645caf410eeab1a0e29aa2297c8d8
kciouv
commented
1 week ago Fixed with https://github.com/bisq-network/bisq2/commit/7ebc9e9de84645caf410eeab1a0e29aa2297c8d8
Great fix! ACK
Based on https://github.com/bisq-network/bisq2/pull/2296 Rebased on Master.
The version at https://github.com/bisq-network/bisq2/pull/2296 had multiple buttons and text display which is not really needed. This version reduce the UX elements to the minimum. It also improves the display of the error and includes the Bisq Version and OS version to the text which should be used for reporting.