search

bisq-network / bisq2

GNU Affero General Public License v3.0
140 stars 53 forks source link

Add BIP21 QR codes for bitcoin addresses #2361

Open suddenwhipvapor opened 2 days ago

suddenwhipvapor commented 2 days ago

From a user's message, which I found interesting:

Would it be possible to add BIP21 qr codes? To make it easier to use mobile app wallets for example... https://github.com/bitcoinibips/blob/master/bip-0021.mediawiki

HenrikJannsen commented 1 day ago

Link is broken.

kciouv commented 1 day ago

@HenrikJannsen Pretty sure the link is to https://github.com/bitcoin/bips/blob/master/bip-0021.mediawiki

As far as I know we don't currently import a QR lib; is there a preferred one in the Java ecosystem? I know that in bisq1 the attached QR lib caused some significant release size bloating. I've used nayuki's multi-implementation library across a few languages and generally find it pretty much fine (and the reference implementation of that library is in Java); historically when in the JVM ecosystem I've used QRGen, but it seems like it might be bitrotting and I don't know what the preferred lib is now.

BIP-0021 is easy (to generate), so if we have a QR lib we like it's a pretty easy feature to add.