search

bisq-network / bisq2

GNU Affero General Public License v3.0
171 stars 64 forks source link

Use JRE for binaries instead of JDK #2681

Open HenrikJannsen opened 1 month ago

HenrikJannsen commented 1 month ago

Currently we package the same JDK version used for the build into the binaries. We should use the JRE (of same java and vendor version) instead to safe about 60 MB on file size.

The BisqToolchainResolver would need an extension to be used for the packager. The download path is exact the same just jdk will be jre.

The getJPackageJdkDirectory method in PackagingPlugin delivers the path for the runtime. This would require changes to support the JRE.

HenrikJannsen commented 1 month ago

@alvasw Do you see any issues with that? @rodvar Would you be interested to work on that?

rodvar commented 1 month ago

sure @HenrikJannsen I can have a look!

rodvar commented 1 month ago

starting work on this one

rodvar commented 1 month ago

@HenrikJannsen just did some initial tests, it looks like this is as easier as changing the urls to use jre instead of jdk. zulu doesn't have any specific subdirs for jre, so no need to change the Packaging plugin.

The download size is significant, but the final binaries doesn't get much of an improvement... shall I send a PR to discuss anyways?

rodvar commented 1 month ago

@HenrikJannsen just did some initial tests, it looks like this is as easier as changing the urls to use jre instead of jdk. zulu doesn't have any specific subdirs for jre, so no need to change the Packaging plugin.

The download size is significant, but the final binaries doesn't get much of an improvement... shall I send a PR to discuss anyways?

clarified the above on a matrix chat. We need to keep the JDK resolver as is, but the idea is to build a new JRE resolver and set it up in the jpackager to be used for binaries (as opposed to let it use the jdk bins as it is now