search

bisq-network / bisq2

GNU Affero General Public License v3.0
165 stars 62 forks source link

Add trade duration restriction for trades in "bisq easy" trade protocol #2768

Open SebZiHub opened 1 week ago

SebZiHub commented 1 week ago

Hello team,

Motivation for this feature request: As a trade maker, I often find myself in the situation that takers accept a trade but do not respond for days. They appear to be offline, according to their profile information, and the trade never gets any progress. Specially in trades where I have already send my payment information, I have the impression that those unwillingly to even take a trade seriously might see my personal information, although there's no need to know my personal name and IBAN etc. anymore after days or weeks (they might close the trade from their side or just never respond). I can't close the trade either, as this might result in a trade policy violation.

In the last trade I did over Bisq1, there was a time frame of 4 days. Wouldn't it be beneficial to have a restriction like that in the "bisq easy" trade protocol also? The 4 days could start counting after the offer was taken. If the 4 days pass without have the trade being closed, a mediator could be invited to the chat, or closed automatically in some cases (e.g. when the taker never received the payment information because of total inactivity). What do you think?

Greetings and thank you for your work.

suddenwhipvapor commented 1 week ago

Hello, don't worry about canceling the trade in those situations, as it will not evolve into a ban, when the peer is unresponsive for more than 24hrs you can reject it without issues, this will be more clearly indicated in a next version

SebZiHub commented 1 week ago

Hello, thanks for checking. I was not aware that this kind of time frame already existed. As you mentioned, it would be helpful it this was somehow made more visible. In Bisq1, it's more prominent and thus more clear to both parties involved, I believe.

suddenwhipvapor commented 1 week ago

It will be made clearer in a next release, in the popup that appears when you go to cancel a trade

HenrikJannsen commented 1 week ago

The trade rules have been adjusted in v2.1.0 to make it more clear as well as the warning popups when canceling a trade that in such cases its justified to close the trade.

The problem with a seller having sent their data but the buyer violates the trade contract should be reported to the mediator who can further inform the moderator to ban such buyers. Of course as buyers have nothing at stake they can simple create a new profile but or now we do not have a good idea how to improve that. Ideas welcome....

Best for sellers to use payment methods which do not leak plainly private data like real names.

Also sellers can start by a chat conversation to get a better feeling for the trustworthiness of the buyer. As well to reject the trade in case there are doubts. I would also recommend to sellers to wait that buyer has sent first their BTC payment data, as that would at least show some indication of activity. Maybe we find some improvement byutilizing the new "activity" indicator.