bisq-network / bisq2

GNU Affero General Public License v3.0
194 stars 68 forks source link

Publish Bisq 2 libraries for re-use in Bisq-mobile #2951

Open HenrikJannsen opened 4 weeks ago

HenrikJannsen commented 4 weeks ago

We need to publish the Bisq 2 modules used in Bisq-mobile as jar libraries.

We could use jitpack instead/additional to the local maven repository, but this will require verification. I think local maven is at least during development easier and faster.

We could also consider to create a shadow jar to pack all into one jar. But I think having individual jars is probably better. If we package all we must avoid the non-android compatible modules like java-se, os-specific,apps`,...

When I used that approach in my POC branch I had issues with plugin id("bisq.java-library") as on android that caused a missing dependency to 'bisq::platform' which is not a java library and I did not manage to publish that. I guess it has to be recreated on the android project. By replacing the id("bisq.java-library") plugin with:

java
id("bisq.java-conventions")

I could resolve that issue.

At the network module when adding the publish tasks (at network-identity) it caused problems on the network sub-projects (like tor). I did not manage to resolve those issues. Some Gradle experts will know for sure how to deal with that....

HenrikJannsen commented 4 weeks ago

@rodvar Can I assign that to you?

rodvar commented 4 weeks ago

@HenrikJannsen sure thing!

rodvar commented 3 weeks ago

starting work on this one

rodvar commented 3 weeks ago

Current status: