bisq-network / compensation

@bisq-network contributor compensation requests
https://github.com/bisq-network/docs/tree/master/dao/phase-zero#how-to-request-compensation
20 stars 16 forks source link

For Cycle 38 #1121

Closed alvasw closed 2 years ago

alvasw commented 2 years ago

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
Set Java 11 as Compilation Target dev https://github.com/bisq-network/bisq2/pull/408 We need to target Java 11 for Android Support.
build-logic: Set Kotlin Version Explicitly dev https://github.com/bisq-network/bisq2/pull/412
build-logic: Download and Verify Electrum Binaries dev https://github.com/bisq-network/bisq2/pull/413 The new BisqElectrumPlugin downloads and verifies the Electrum binaries for Linux, OSX, and Windows. The PGP public keys and the fingerprints of the Electrum developers are hardcoded in the plugin. Consumers of the plugin can set the electrumVersion property to specify the version.
Bundle Electrum Binaries with Bisq dev https://github.com/bisq-network/bisq2/pull/414 Package the Electrum binaries after verifying the signatures and copy it to the Java resources.
Github Actions: Install Bitcoin Core on CI dev https://github.com/bisq-network/bisq2/pull/417 The bitcoind integration tests depend on Bitcoin Core.
Run Bitcoind Integration Tests on CI dev https://github.com/bisq-network/bisq2/pull/418 Check whether bitcoind is installed and run integration tests depending on its result.
ElectrumBinariesDownloader: Close all streams after download dev https://github.com/bisq-network/bisq2/pull/420
Bisq-Plugin: Add gradlePluginPortal Repository dev https://github.com/bisq-network/bisq2/pull/422
DaemonProcess: Log process start config dev https://github.com/bisq-network/bisq2/pull/426
desktop/desktopapp: Target Java 17 dev https://github.com/bisq-network/bisq2/pull/436 JPackage cannot sign the DMG image on Mac because the JavaFX 11 Mac dylib libraries are not signed. It's less work to target Java 17 (and JavaFx 17) instead of adapting the build process to sign the dylib libraries before creating and signing the DMG image.
Proof of Concept: Pricenode Extraction dev https://github.com/bisq-network/bisq/pull/6292 PoC: https://github.com/alvasw/bisq-pricenode
PR Review: Add new bisq-pricenode build dev https://github.com/bisq-network/bisq-pricenode/pull/4
PR Review: Add re-usable Gradle task postBuild dev https://github.com/bisq-network/bisq-gradle/pull/1
Fix race condition in bitcoind unconfirmed txs dev https://github.com/bisq-network/bisq2/pull/441
  • Move initialize and shutdown to BitcoindWallet
  • Bitcoind: Create custom JUnit Extension
  • Bitcoind: Use custom extension in integration tests
  • BitcoindInitialRegtestMiningTest: Wait until all blocks mined
  • BitcoindRegtestSetup: Make regtest block mining blocking
  • BitcoindSendUnconfirmedTest: Wait until tx broadcasted
Fix race condition in elementsd unconfirmed txs dev https://github.com/bisq-network/bisq2/pull/444
  • ElementsdVin: Add missing peginWitnesses field
  • Elements: Make regtest block mining blocking
  • Elements: Move regtest classes to its own package
  • ElementsSendUnconfirmedTest: Wait until tx broadcasted
  • ElementsdVin: Add issuance field
CI: Install Elements Core and Run Integration Tests dev https://github.com/bisq-network/bisq2/pull/445
  • Github Actions: Rename setup-bitcoin-core to install-wallets
  • Github Actions: Install Elements Core
  • Wallets: Enable Elements Integration tests (when elementsd installed)
PR Review: Add re-usable Gradle task postBuild dev https://github.com/bisq-network/bisq-gradle/pull/1 Proof of Concept: Plugin - https://github.com/ghubstan/bisq-post-assemble-plugin/tree/convert_to_standalone_plugin
Proof of Concept: Plugin Consumption - https://github.com/alvasw/bisq-pricenode/tree/adjust-build-files-n-scripts
PR Review: Add bisq v1 post build plugin dev https://github.com/bisq-network/bisq-gradle/pull/2 pluginManagement block was missing.
Bisq 2 Web UI: Add Bisq 2 repo as a Composite Build dev https://github.com/salokiam/bisq2-web-ui/pull/1
  • Make Gradle Wrapper executable
  • Update Gradle Wrapper to 7.5
  • Add Bisq 2 repo as a Composite Build
Add Bisq 2 identity module as a dependency dev https://github.com/salokiam/bisq2-web-ui/pull/2 JitPack was missing as a repository.
PR Review: Fix plugin management spec in settings.gradle dev https://github.com/bisq-network/bisq-pricenode/pull/8
dev 6000 Total for items above.
chimp1984 commented 2 years ago

ACK

ripcurlx commented 2 years ago

As dev team lead I approve this compensation request for dev based on https://github.com/bisq-network/compensation/issues/1121#issuecomment-1202269893. Please submit your compensation request to the DAO for voting and post the transaction ID here afterwards. Thanks!

alvasw commented 2 years ago

f217e0f8cb8b529597ec9f7f4ef76f2e1dc8178633f2fbe237fcc1bb3461bd3f

ghost commented 2 years ago

Issuance by Team:

team amount BSQ amount USD
dev 8000.00 6000.00

Total Issuance: 8000.00 BSQ (equivalent to: 6000.00 USD)

MwithM commented 2 years ago

Closed as accepted