search

bisq-network / compensation

@bisq-network contributor compensation requests
https://github.com/bisq-network/docs/tree/master/dao/phase-zero#how-to-request-compensation
20 stars 16 forks source link

For Cycle 41 #1179

Closed alvasw closed 1 year ago

alvasw commented 2 years ago

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
BitcoindMineInitialRegtestBlocks: Increase timeout to 1 minute dev https://github.com/bisq-network/bisq2/pull/511
Let Bitcoin Core manage its wallet files dev https://github.com/bisq-network/bisq2/pull/512 Currently, we store the Bitcoin Core wallet files in Bisq's data directory. The disadvantage of this approach is that we cannot run Bitcoin Core on another machine. This change lets Bitcoin Core fully manage all its wallet files.
Use one global bitcoind instance for all integration tests dev https://github.com/bisq-network/bisq2/pull/513 At the moment, each test class starts its own Bitcoin Core instance. This causes slow CI tests and high resource usage.
Electrum: Enable Windows Support dev https://github.com/bisq-network/bisq2/pull/514
Windows: Switch to regular Electrum executable dev https://github.com/bisq-network/bisq2/pull/515 Switch from portable Windows executable to regular executable.
Electrum: Fix ElectrumX (server) hostname dev https://github.com/bisq-network/bisq2/pull/516 Electrum assumed that ElectrumX (server) is running on the same host. This assumption is not true on Windows because ElectrumX is not officially supported on Windows. Most devs run the ElectrumX server in a Linux container or VM and connect to it from Windows.
GitHub Actions: Use absolute bin path (ElectrumX) dev https://github.com/bisq-network/bisq2/pull/519
Create json-rpc library dev https://github.com/bisq-network/bisq2/pull/520 The json-rpc library that we are currently using doesn't properly clean up all resources. On Windows it blocks the Electrum Daemon. It's better to create a new simple json-rpc client that supports batching and asynchronous calls.
Electrum: Migrate from CLI to JSON-RPC dev https://github.com/bisq-network/bisq2/pull/521 We generated the config file using the electrum binary in the past which lead to several issues. Now, we manually generate the config file and no longer need to rely on the CLI.
Electrum: Switch to new JSON-RPC library dev https://github.com/bisq-network/bisq2/pull/522 The old JSON-RPC library blocks Electrum on Windows after a few RPC calls. Adapting the old JSON-RPC library turned out to be harder than switching to a modern approach (supporting asynchronous calls, ...). Then new library is more flexible and performant.
Electrum: Remove Jackson Databind dependency dev https://github.com/bisq-network/bisq2/pull/523 This dependecy was needed for the old JSON-RPC library.
BitcoindGetAddressInfoResponse: Follow field naming convention dev https://github.com/bisq-network/bisq2/pull/524
Move AssertJ testing library to 'java-conventions' project type dev https://github.com/bisq-network/bisq2/pull/525
JSON-RPC: Specify OkHttp lib version using BOM dev https://github.com/bisq-network/bisq2/pull/526
Add HttpLoggingInterceptor to JsonRpcClient dev https://github.com/bisq-network/bisq2/pull/527
JSON-RPC: Specify OkHttp BOM and Moshi in version catalog dev https://github.com/bisq-network/bisq2/pull/528
Electrum: Remove setters in RPC response classes dev https://github.com/bisq-network/bisq2/pull/529
GitHub Actions: Remove unused ids from build.yml dev https://github.com/bisq-network/bisq2/pull/530
GitHub Actions: Rename 'setup-bitcoin-core' action to 'install-wallets' dev https://github.com/bisq-network/bisq2/pull/531
Use single ElectrumXServer instance for all integration tests dev https://github.com/bisq-network/bisq2/pull/532
Use single Electrum instance for all integration tests dev https://github.com/bisq-network/bisq2/pull/533
dev 6000 Total for items above.
ripcurlx commented 2 years ago

As dev team lead I approve this compensation request for dev. Please submit your CR to the DAO for voting and post the transaction ID here afterwards. Thanks!

@alvasw Do you have an idea how far we are away from getting Bisq 2 production ready with Bisq easy?

alvasw commented 2 years ago

@ripcurlx I'll PMed you a more detailed list. We're mostly feature complete. Chimp implemented almost everything before he left. I'm at the moment, verifying that Bisq 2 is working on all operating systems.

A rough roadmap/todo-list:

alvasw commented 2 years ago

9c97dce81b2501ebf9a8e51216719996f1c2e8579518cb6a4993dcc34e69f499

ghost commented 1 year ago

Issuance by Team:

team amount BSQ amount USD
dev 8000.00 6000.00

Total Issuance: 8000.00 BSQ (equivalent to: 6000.00 USD)

MwithM commented 1 year ago

Closed as acceped.