axpoems
commented
3 months ago 05b4ca8635762433ff1320aaabbe9c8abd4d120a69719e4450ddcd79c6260457
Closed axpoems closed 2 months ago
axpoems
commented
3 months ago 05b4ca8635762433ff1320aaabbe9c8abd4d120a69719e4450ddcd79c6260457
ghost
commented
2 months ago Issuance cannot be displayed as there were errors in the comp request
ghost
commented
2 months ago Issuance cannot be displayed as there were errors in the comp request
ghost
commented
2 months ago | team | amount BSQ | amount USD |
|---|---|---|
| dev | 10377.36 | 22000.00 |
Total Issuance: 10377.36 BSQ (equivalent to: 22000.00 USD)
MwithM
commented
2 months ago Closed as accepted
Summary
10377.36Contributions delivered
#1698
Nit. I have seen that occasionally we are getting scrollbar detected when it shouldn't
(…)
Fix misaligned offerbook messages
Introduce the first iteration of the new user avatars - The Bisq 2 CatHash
• Introduce the Cathash images. (*)
• Prepare Cathash image set.
• Add configuration to generate the user avatars.
#1706
Nice improvements! Now this is much more flexible when it comes to number of images and buckets.
Fix hidden text in report to moderator popup
Add offers' filter dropdown menu in BisqEasy Offerbook
• Add warning before applying 'Ignore user' action
• Add filter offers dropdown menu.
• Misc refactors.
Revisit styles of Bisq Easy offer messages
• Relocate reputation to be nearer and alongside the user avatar.
• Reduce size of takeOfferButton size and moved it closer to the offer text details.
• Decrease font size of the message bubble and increase line spacing.
• Change colour of the my message bubble to a dark desaturated green.
Add additional filter in Bisq Easy Offerbook to filter offers by peer reputation
• Add filter by peer reputation
• Rename "offers filter" to offerDirectionOrOwnerFilter, reorder its items and change strings
• Rename the remaining robohash to cathash.
• Fix dropdown menu items sometimes missing to be resized on first run.
Update offerbook according to new revision
Towards #1718
• Update market channel selector and header titles.
• Place create offer button into the offerbook header.
• Place offerbook search box into the subheader.
#1738
Good catch! Added one comment.
(…)
Apply dimming effect to fiat logos and market titles
• Apply dimming effect to fiat logos and market titles.
• Highlight selected items in sort and filter dropdown menus (including reputation and offer types).
• Remove unused code.
#1748
Nice changes!
From the UX perspective, I don't see the need for the user to be responsible (or partly responsible) for retrying the messages - especially in the case of ProtocolLogMessages.
What about having a cron job that retries these messages? At least for protocol type of message.
#1750
I looked into this more. It fails every time you create an offer and then switch markets and attempt to create a new one there.
The issue was that the price quote was not being reset property.
I added the fix for this in #1755
Add display hint for applied market filers
• Add display hint for applied market filers.
• Set show All markets by default.
• Adjust the dimming effect, remove on market titles and reduce it for market logos.
#1754
A few things: You need to sign your commits, also try to follow the Bisq guidelines when making commits and use the style conventions.
You can read more about this in the contributing guide as well as the developer guidelines.
Fix TradeWizardPriceController throwing exception
Price controller was throwing an exception upon percentage validation
It worked well while creating offers in one market, but when switching markets and creating a new offer it failed since it was using the previous quote price. Thus, this resets the missing fields every time we use the TradeWizard.
Review general code guidelines
Improve user avatars design
• Increase background diameter.
• Create and add new background overlay patterns.
• Add body layer with two size options.
• Add chest and overlay layers with two size options.
• Correct design bug in ears to distinguish from a background with the same colour.
• Add full colour spectrum for the small and bigger ears.
• Add four new face shapes.
• Create new face overlays and fix existing ones according to new face shapes.
• Adapt CatHash algorithm to the new design scheme.
Refactor Cathash encoding
• Remove unnecessary ordered map.
• Use Optional instead of checking null.
Add number of notifications pending to be read in private chats
• We have the global notification count in private chats (sum of all the unread notifications).
• This introduces the notification count per chat inside the tab.
Add versioning for avatar image creation
This allows for future improvements in the current CatHash solution.
Delete unused robohash images
Rename existing bucket config to match version 0
Fix user profile selection not working after adding new profile bug
• Add missing listener to userProfiles
• Refactors in UserProfileSelection
Fix inconsistent market logo effect bug
• Fix market logo effect not matching selected row.
• Make updateItem() from markets table decide when to lit the market logo depending on whether that row is selected or not.
• Minor refactors.
Keep market item selected while and after using search bug
• Add listener to search predicate to always keep selection visible in table view.
• Prior to this, both during and after search, the selection marker disappeared.
Add favourites system to offerbook markets enhancement
• Add capability to store favourite markets in user settings.
• Use market favourites in offerbook as a way to pin markets.
• Introduce new icons dedicated to favourites.
#1825
#1826
Update Bisq Easy texts according to new protocol
• Update trade rules
• Update reject trade warning message
• Update cancel trade warning message
#1832
I reviewed and updated it in #1846
Review and update take-offer status feedback overlay
• Use as waiting icon the Bisq Easy logo.
• Show take-offer state for at least 8 seconds (less than that the user is not able to read and looks confusing).
• Unify overlays so that we don't see interruption between them.
Improve style of matching offers table in trade wizard
• Change matching offers table styles to match the standard style of tables used in the app.
• Add selection marker column.
• Remove unnecessary and confusing column used to select offer.
• Minor refactors.
Improve visibility of messages with scroll down indicator
• Apply a gradient buffer when scroll down icon is shown to make a smooth disappearance and improve experience.
• Change icons to better fit the scroll down icon and number of messages indicator in the chat window.
Add "Only favourites" filter and other improvements
• Set height correctly for favourite markets and improve paddings.
• Show selected market after applying a new filter to market channel items list.
• Hide horizontal scrollbar in private chats list.
Add alert banner to deliver Bisq offical communications
• Resolves #1877
• Adds dedicated component to show alerts.
Introduce Bisq broadcast icon
• Add Bisq boradcast icon to alert banner.
• Change banner's warning background colour.
• Change headline font.
Improve published users indicator
• Use published instead of active and specify that it refers to profiles in the title label.
• Use tooltip icon and update string to better explain when a profile is published and that this is tight to the user.
Improve reputation import account age instructions
• Improve instructions flow.
• Update request authorization to get the value from the model instead of the clipboard.
Updates in icons
• Use MaterialTextArea instead of field in import account age instructions.
• Add new chevron icons (plus missing in white chevron) for the dropdown menus.
• Correct design flaw in small ellipsis icon.
• Improve help icon for better visibility.
• Add mini close icons for the display hints to avoid rescaling.
Fix alert banner paddings
• Fix paddings when showing an alert banner (both in the general case and when colliding with another Bisq Easy notification).
Contributions in progress