axpoems
commented
1 month ago c65e22695de3288bfaa86545d2c42471076e06794615303ef6085df9b43e22b4
Open axpoems opened 2 months ago
axpoems
commented
1 month ago c65e22695de3288bfaa86545d2c42471076e06794615303ef6085df9b43e22b4
Summary
7085.02Contributions delivered
#1901
The following comment is not addressed with the latest changes.
Help text is not getting back (…)
Add custom style to take offer button
• Use Buy/Sell Bitcoin instead of "Take offer".
• Use different colours for each action.
Only send system notification for real time messages
While online, for each message we
(1) show the badge and
(2) send a system notification.
The latter should be avoided when a message was received before the user went online.
This prevents a flood of system notifications at start-up.
#1967
I think we should also dismiss the badge in the tab automatically after 5 seconds (or another solution so that the user sees that there's a change but it's handled automatically). This can be done when we work on the next chat iteration.
Fix alignment issue in create offer wizard
using a different language other than English.
#1993
Suggestion for further improvements in PR #1994.
Update number validation to be more strict
• Use a more strict number validation to prevent cases like "123abc" to be flagged as valid.
• Force a validation after updating the switch for both min. required rep. and diff. factor.
This avoids getting into an inconsistent state when switching back to default with a previous errorLabel.
• Misc. refactors and improvements.
Add price step when creating a Buy offer
• Add price step when creating a Buy offer. This now follows the standard as when creating a Sell offer.
• Remove option to set price when seller takes a Buy offer.
• Changed order of payment methods and amount, so that the order is price - amount - payment methods.
Fix encoding issue on Windows
• Replace PauseTransition with UIScheduler
Unify markets table style in trade wizard
• Use search fiat currency box as column title.
#2016
Add overlay to accept or reject new seller's price feature
This PR resolves better "Case 2: Buy offer made in 2.0.3 and taken with 2.0.2", as explained in #1999 (comment).
Now, instead of throwing when there's a mismatch in price spec, we allow the buyer to decide if he wants to accept or not.
Change reputation service to use a predefined 5-star system improvement
• Introduce a table score (defined in Improve reputation score algorithm and display #2014 (comment)) to calculate the stars representation. This new system allows for half a star.
• Add new icons to cover this representation.
• Remove changing star colour in trade wizard, since with the new table style this is not necessary anymore.
#2024
I would use the design style for system messages here. This aligns with the suggestion that @HenrikJannsen was making in the issue, which is to add an entry by default at the beginning.
Refactor: Use upper limit to return number of stars
Add feedback for buyer in price step feature
• Update UI in price step.
• Add feedback section for the buyer which guides the user on what to choose and explains why.
Refine Bisq Easy offer message improvement
• Update title in offer message.
• Format peer nickname and open user profile when clicking.
• Add min width to peer offer message.
• Fix copyToClipboard for offer messages.
• Truncate nickname when used in messages.
• Add code-block style.
Various fixes and improvements for buyer as maker case
• Avoid showing pop-up when rejecting/cancelling using the overlay.
• React on trade state changes to decide whether to show the accept/reject seller's price overlay.
• Minor refactors.
Fixes in trade wizard's price step
• Fix overlay not opening up with transition effect on first run.
Show amount step before price in trade wizard
Show amount step before price in trade wizard, which:
• Relaxes the min/max amounts that are allowed for trading, since price spec is not taken into consideration.
• Allows for trade price recommendation/decision making based on the amount.
Add offer list in Bisq Easy offerbook
Add offer list in Bisq Easy offerbook to enhance searching offers.
Make Markets and Offer List columns collapsible
Make Markets and Offer List columns collapsible
Improvements in Offer List
• Use reputation score and user nickname as default sorting method for offers list.
Exclude reputation score from hash in OfferMessageItem
Contributions in progress