alvasw
commented
1 week ago 29f3b75e9050ded89c6801b2e9e9b037e4a390bc42a01d371f2ee2b60588c4b4
Open alvasw opened 1 week ago
alvasw
commented
1 week ago 29f3b75e9050ded89c6801b2e9e9b037e4a390bc42a01d371f2ee2b60588c4b4
Summary
7500.00Contributions delivered
The Bisq P2P ports are exposed to the local network even when Tor is the only selected network. This is only needed on Whonix.
Users have to manually update Bisq and to support auto-updates we need to ship msi files. We can't use the existing exe file because it requires user interaction during installation or updating.
We send a
stopRPC call and wait for the subprocess after receiving asuccess/okmessage. This is unnecessary because we received asuccessreply already.We parse stdout and wait for the "init message: Done loading" line to
detect when bitcoind is ready. After seeing this line, we stop reading
stdout causing the stdout buffer to fill up. When the stdout buffer
fills up, bitcoind waits until its parent process reads from it but this
unfortunately never happens leading to a deadlock.
The assumptions and expectations of the tests are wrong.
The test mines blocks and waits until it sees the block hashes of the
mined blocks over ZMQ. Unfortunately, ZMQ publishers are stateless and
can't re-transmit lost messages [1]. Consequently, the test was wrong.
The fixed test subscribes to the publisher, starts mining blocks, and
waits until it observes a new block hash.
The assumptions and expectations of the tests are wrong.
The implementation is wrong.
The test is wrong.
Both fields were added in Bitcoin Core 24.0.1.
warningstring was replaced by awarningsJSON array in Bitcoin Core 25.0.The tests use the installed bitcoind binary. To make the test failures
reproducible it's better to run the tests with the officially supported
Bitcoin Core version.
The wallets.regtest can't depend on any Bisq 2 API to be able to re-use
the bitcoind regtest module in Bisq 1. I migrated our BitcoinJ fork to
the upstream version but Bisq 1 uses deprecated/removed BitcoinJ APIs,
and it's too risky to update critical code without testing the changes.
Bisq 1 doesn't have any bitcoind-based integration testing code and
quicker to re-use Bisq 2 bitcoind integration test infrastructure.