Closed dmos62 closed 4 years ago
- #3890 Improve readability of the daily burnt BSQ chart, 1470 BSQ: This is the first set of changes to these charts that primarily affected the daily burnt BSQ chart, but also forced the monthly issued BSQ chart's Y-axis to include zero. Changes to the daily BSQ burnt chart helped with outlier distortion and general noisiness in the data series.
I think as mentioned in our Keybase chat I think it is fine to include this PR into our cycle 10 dev budget, because of the reason mentioned above.
DAO proposal transaction ID: ed4b2d982a056ff0a02d0934bf7e1ad1385e003ae1f5cb591017d40979cda70f
I'm getting a weird bug with my window manager where I couldn't copy-paste the tx id or switch windows. Something to do with my wm not handling Bisq popups properly. I had to copy the id by hand, so there might be a typo. I'll try and get my wm sorted tomorrow.
@dmos62 I suggest checking the log for the txid if you're not able to copy from client. Sounds painful to copy by hand.
@dmos62 I suggest checking the log for the txid if you're not able to copy from client. Sounds painful to copy by hand.
Haha, that's smarter. Apparently, I didn't make a mistake. The ID is correct as posted above.
Was accepted
Summary
BSQ requested: 1470 (= 900 EUR @ 0.67 USD/BSQ and 0.91 USD/EUR)
Contributions delivered
Out of the PRs below, I am requesting compensation for only the first one. The first pull request below was submitted during Cycle 9, before the new compensation rules were introduced (compensated contributions must align with priorities). @ripcurlx discussed it with me and led me to believe that seeking compensation on this cycle shouldn't be a problem, rationale being that it was submitted before compensation policy was changed.
The second DAO charts PR was submitted during Cycle 10; therefore, I'm not asking for its compensation.
Changes to DAO charts:
#3890 Improve readability of the daily burnt BSQ chart, 1470 BSQ: This is the first set of changes to these charts that primarily affected the daily burnt BSQ chart, but also forced the monthly issued BSQ chart's Y-axis to include zero. Changes to the daily BSQ burnt chart helped with outlier distortion and general noisiness in the data series.
#3910 Add new BSQ issued v. burnt chart, 0 BSQ: This PR introduced a monthly chart for comparing BSQ issue against BSQ burn. According to donated use-cases in a dedicated issue thread, this was the most common use for the DAO charts.
Other:
Contributions in progress
This is my first venture into the setup and messaging parts of Bisq. It's somewhat intimidating and relaxing at the same time, because while the system isn't small or simple, I find the codebase to be well kept and easy to read.