Recently, we had a quite substantial PR queue build-up. Hence, we decided to talk about the whys and hows and how we can improve the workflow. The first part is seen as an informative Presentation on a suggested workflow, for the second part (the optimization part) we hope for a few suggestions from the audience.
Agenda
howto
setup git (your id, pgp)
fork bisq
feature branch
commit little, commit often
check yo' stylin (try to match the surroundings)
commit only changes related to the PR in question (no import reorgs)
create PR
await response from reviewers
react, if change requests are not reacted to within 30 days, PR will be closed (no compensation)
rebase and force-push you feature branch if necessary
ask for compensation
why does it take so long until PRs get merged
formatting issues
unnecessary code reorgs
conflicts
...
hence, PRs queue up
maintainers are overburdened
nothing moves
optimize workflow
use travis to check for formatting?
use travis to check for bugs? (FindBugs, etc.)
introduced the 30 days deadline
we will be more rigorous with closing PRs if we feel that too much basic stuff is off
Recently, we had a quite substantial PR queue build-up. Hence, we decided to talk about the whys and hows and how we can improve the workflow. The first part is seen as an informative Presentation on a suggested workflow, for the second part (the optimization part) we hope for a few suggestions from the audience.
Agenda
howto
why does it take so long until PRs get merged
optimize workflow
Schedule
When: cancelled, reschedule ~Friday, 2019-11-22 13:00 CET~ Duration: 1,5h How: https://zoom.us/j/753072189, web link https://zoom.us/wc/join/753072189?pwd=