Closed chimp1984 closed 3 years ago
The chart shows all data in BSQ.
Very nice. Definitely support project to better understand DAO revenue and expenses!
Q - BSQ availability for purchase? Selling / buying requests - data on that somewhere that would be any value of including?
Currently it is very difficult to get a good idea what is the revenue of Bisq, how much is the share of BSQ fees vs. BTC fees and if the relationship of trade volume and total fees is as expected. The current charts in that area are not reflecting well the data and are too poor from features to get some real value out of them (e.g. no tooltip for data points, no naviation/zoom to time periods).
I am working on an improved chart compenent with a timeline component and a date filter so it enables to select a certain time period and make it easier to navigate through the data. I also added toggle buttons as data legend for the chart series so one can show/hide certain data series.
DAO internal data
Data sources/series:
We could also consider to split it into 2 charts: One with the fee vs comp requests and one with reimbursement and burned BSQ from proof of burn for delayed payout txs.
The chart shows all data in BSQ. We could add a feature to convert it to USD based on average BSQ and USD prices. As a main goal is to show relationship between revenue and expenses (comp requests) I think this is achieved without the USD conversion and I will leave that out in the initial delivery from my side (as I want to limit effort on that project). But any dev is very welcome to extend that and add that later. As well as using average values instead of plain data might be useful to filter out outlies. Outlier filter for initial data, specially for the BSQ price will be still used as we have it.
Blockchain based data
We have different addresses where BTC as trade fee or BTC from delayed payout transactions (DPT) are received. We had several burning mans [1] and we still receive funds on the old addresses. Funds to the default address is expected from users who have deactivated the DAO. Why we receive still funds on the other addresses (not much and rarely) is not 100% clear but it is likely that the DAO state of the uers got out of sync and got stuck to the result of that cycle where that BM was active. We do not send BTC fees anymore to any of the addressed defined as DAO parameter but use the data from the filter. So if we still receive funds it is either from users with very old versions (they should not be able to trade anymore but maybe they still can create offers?) or from funds from the DPT.
For new data we have a clear separation now from the addresses, so it should be easy to get the numbers from BTC fees and the numbers from DPT (including the old addresses which should be only DPT amounts).
The real reevenue in BTC fee includes the funds to the victims. We can use that number for estimating the BTC fees in the period when we did not had separated the receiver address as the BTC is statistically 50% split between victims and BM.
We have to connect those data with the data we get from the DAO and figure out if the results are as expected even for older data it will not be perfect it should give a good estiamtion.
Related efforts
Limitation
This is pretty fresh WIP and many details are not well thought out yet. I also want to keep effort from my side limited and spend already too much time on that. So I plan do deliver only the MVP and any contributor is welcome to improve and fine tune as well to apply the new chart component to other areas. But before getting too far into details it would be good to coordinate with @wiz, @soft_simon and @ripcurlx about their plans, ideas and state of work to not duplicate efforts.
References
[1] https://github.com/bisq-network/roles/issues/80 [2] https://github.com/bisq-network/roles/issues/80#issuecomment-723577776 [3] https://github.com/bisq-network/projects/issues/31 [4] https://github.com/bisq-network/projects/issues/41 [5] https://docs.google.com/spreadsheets/d/1o-I5fAx7DJRVqYjW8fPbo0ztlGIhIZ1EM2iLc5aEHnA/edit#gid=498306346