Open cbeams opened 6 years ago
Almost 100% review this cycle. That includes talks on design and testing. We managed to release most of it after some minor issues.
We pre-released v1.4.0, v1.4.1 and publicly released v1.4.2. Besides taking care of issues together with @cd2357, who got the triage permission for the Bisq repository recently, I mainly worked on our upcoming build system to be able to switch to a LTS Java version and most up-to-date JavaFX version.
There was a lot of work to get 1.5.0 released with all the issues we had with 1.4.2. So far 1.5.0 seems to be at least not worse than 1.4.2 which is a good thing. There are still quite a lot of support cases lingering from 1.4.2 so I would consider stronger incentives for users to upgrade if we don't get a good uptake.
We released v1.5.0 without a pre-release phase as it is not possible to trade with older versions because of the trade protocol changes. Also we wanted to get the bug fixes introduced in v1.4.2 out there as soon as possible. We do have a 70%+ adoption rate of v1.5.0 already, so I hope support cases should decrease soon. I do check now on a daily basis all GitHub notifications to react in-time on issues and PR changes to prevent unnecessary blocks from maintainers side.
Although we fixed with v1.5.1 already most of the issues experienced in v1.5.0, v1.5.2 shipped as a regular release should finally bring some calm over the holidays into mediation and support (hopefully).
I continue to check on a daily basis all GitHub notifications to react in-time on issues and PR changes to prevent unnecessary blocks from maintainers side. Over the holidays I wasn't able to deliver on this, but I'll try my best to clean out my notifications log today.
[EDIT] I did forget to mention that I had to renew my Code Signing Certificate for Windows for €91.55 (~$111). I'll add this to the desktop maintainer amount. [/EDIT]
A fair few issues going on from the previous releases which added to the review and merge workload. Reviews are in general reported separately but there is an overhead of having to monitor PRs and handling the releases.
Voting in last cycle failed which so far caused less problems than I would've expected. The DAO code worked as expected and contributors have been very good about it.
I was unwell large part of this cycle. Did minimal review and merge, not requesting anything for the maintainer role.
I haven't done all that much on this role except being moral support for @ripcurlx
Still doing limited maintainer work
We released v1.6.3 and v1.6.4. v1.6.4 was a follow-up release after a v1.6.3 pre-release as we wanted to filter out one infrastructure change and a graceful restart if banned seednode addresses are misconfigured. This was triggered by myself after I published a seednode address to be banned that had an incorrect format. As there is no validation in the filter form, but there is one when the bisq.properties file is read on startup this prevented all nodes that stopped or restarted within a time window of three hours to start. The workaround to start again was to remove the bannedSeednodes line from the bisq.properties file. To prevent this in the future I'll add validation to the filter fields and already removed incorrect configured nodes when read in v1.6.4.
This two releases also include a completely new way to create the installers enabling us to move to a LTS Java version again (11) and also to be able to update JavaFX form now on again.
Still doing minimal maintainer work.
We released v1.6.5 - no hotfix this time 🥳 The new build pipeline works pretty fine, except for one Java Heap Space Error that is popping up since v1.6.4.
I had to move Travis from https://travis-ci.org to https://travis-ci.com with the downside that even with the free OS plan we have to ask for 25k new free build credits every now and then. Thanks to https://github.com/maxim-belkin we already have a GitHub action in place that verifies nearly everything the current Travis build does. Probably worth to add the last bit as well and get rid of Travis to reduce future maintenance issues.
I also prepared an additional CodeQL GitHub action to run security checks over the code base as well. I also plan to add a security policy to the repository soon.
All release work has been reported in other posts, @ripcurlx is keeping up the more organized maintenance work.
We released v1.7.0 which was a hard fork because of a privacy issue reported by @woodser. This release needed in-depth testing because of different upgrade scenarios and was deployed without a pre-release version. So far we only saw issue during dispute handling which was addressed in pre-release v1.7.1. Our users started to see lots of DAO not in-sync popups which we weren't aware of before. This is still in investigation to find the exact root cause. We continue to see Java heap errors which should be addressed with version v1.7.2 which will be released soon. Because of vacation I won't be very active over the next three weeks, but I'll try to keep up with my duties as good as possible.
We released v1.7.2 which mainly focused to reduce memory consumption and fixes a couple of minor issues that were introduced in the v1.7.0 hardfork. I wasn't very active in this cycle because of vacation.
We released a [v1.7.3] (https://github.com/bisq-network/bisq/releases/tag/v1.7.3) vacation release which mainly contained minor bug fixes and UI improvements. I returned to attend to my duties as maintainer and was mainly focusing on the Tor v3 support issue this cycle.
We released [v1.7.4] (https://github.com/bisq-network/bisq/releases/tag/v1.7.4) containing the Tor v3 support. So far the release went fine and most of the network already upgraded to Tor v3 addresses as well.
We released v1.7.5 introducing 13 new payment methods and moving all remaining nodes to Tor v3 addresses.
We released v1.8.0 introducing BSQ swaps and major DAO parsing improvements. We had to increase the mandatory version to v1.8.0 as a compatibility issue, when trading with an older version with a specific payment method, surfaced. ATM we haven't set any difficulty for BSQ swaps and are also not enforcing new trading fee validations shipped with v1.8.0. This will change within the next couple of days. As part of the Windows release process I also had to renew my code signing certificate over GoGetSSL (€91,71).
We released v1.8.1 and v1.8.2 improving mediation, extending the API capabilities and fixing lots of smaller issues across the board. I'm a little less active than in previous cycles because of personal reasons, which should change to the better soon again.
/cc https://github.com/bisq-network/compensation/issues/1016
We released v1.8.3 and v1.8.4 improving privacy by automatically deleting past trade data. Besides that lots of small UI improvements and bug fixes.
Improvements
/cc https://github.com/bisq-network/compensation/issues/1041
We didn't release in this cycle as v1.9.0 development took longer than expected.
/cc https://github.com/bisq-network/compensation/issues/1060
We released v1.9.0 (pre-release) and v1.9.1 (public release) introducing the Bisq API and featuring a new navigation structure.
/cc https://github.com/bisq-network/compensation/issues/1088
We released with v1.9.2 a hotfix release based on v1.9.1 including the latest official Tor binary at the time (v0.4.7.7). I blocked one onion address (nlpqkpun5alxgmtfcworaunumrcbpupha6l6perphk45ki7fd736ueyd.onion) and related accounts from trading because of chargeback attempts based on suggestion from @pazza83 and @leo816.
/cc https://github.com/bisq-network/compensation/issues/1088
We released with v1.9.3 a pre-release and v1.9.4 as the public release to improve XMR trading and Tor connectivity.
/cc https://github.com/bisq-network/compensation/issues/1154
We released with v1.9.5 a new P2P status indicator and adding Bitcoin Core v23 compatibility.
/cc https://github.com/bisq-network/compensation/issues/1154
We didn't release a new version last cycle, as we wait for a couple of important changes.
/cc https://github.com/bisq-network/compensation/issues/1154
We released with v1.9.6 updating Tor and removing macOS notarization and Windows code signing.
/cc https://github.com/bisq-network/compensation/issues/1184
Because of major changes in the codebase the v1.9.7 release was delayed.
/cc https://github.com/bisq-network/compensation/issues/1197
We released with the v1.9.7 pre-release and the follow-up public release of v1.9.8 many improvements under the hood to improve resilience of the client and push further the decentralization of Bisq. With this release we also introduced new signers for the public release. Following is the signed public key of @alejandrogarcia83 with my private key.
-----BEGIN PGP PUBLIC KEY BLOCK-----
Comment: CB36 D7D2 EBB2 E35D 9B75 500B CD5D C1C5 29CD FD3B
Comment: Christoph Atteneder <christoph.atteneder@gmail.com>
xsFNBFl5pBEBEACmse+BgUYi+WLTHR4xDwFE5LyEIT3a5t+lGolO3cVkfw5RI+7g
FEpxXzWontiLxDdDi34nr1zXOIEjSgQ7HzdtnFiTRN4tIENCBul4YiCOiyBi5ofN
ejAHqmeiO0KsDBQZBdyiK1iWi6yNbpG/rARwHu/Rx5ouT1YX1hV92Qh1bnU+4j4O
FcePQRNl+4q/SrtKdm047Ikr/LBvy/WYBYe9BcQGhbHI4DrUOSnIuI/Zq7xLF8QS
U/an/d0ftbSBZNX3anDiZjzSmR16seRQtvRO6mehWFNlgLMOGgFeJzPkByTd1TlV
K/KaHKQ71FNkRiP87pwkHZI5zJPAQfve+KmYPwOyETUaX43XOuixqutUV6Lrd0ng
bKe6q4nZDOWi5a4I3+hkrfzaGOKm9TlZoEmpJHh6pa5ULoDnEpKCg5Dgn3NGwokw
57sDAC2mtf41/uSkR20ALN1q4iOLXiHn+T6Z+Uq7aL3OcKGcBu4xC6Jfofmmdfdd
QxEEaeHvAI9ETlKy3tsMhEs5XD6m90rCKLnb97Y8eT/xJL4/oDsxI0o7qICz1nFS
2IhV8xULZ2533vNQPMEbSLoTzgz1OEPYwI1b+YJDFlp1y0XRiEtDZiAFfgsJY7UE
DizfuUFsK5LOkw2+NVmLphDVrDW1MXbhX1xspZDmBG9giE08sPtHj/EZHwARAQAB
zTNDaHJpc3RvcGggQXR0ZW5lZGVyIDxjaHJpc3RvcGguYXR0ZW5lZGVyQGdtYWls
LmNvbT7CwZQEEwEKAD4CGwMFCwkIBwMFFQoJCAsFFgIDAQACHgECF4AWIQTLNtfS
67LjXZt1UAvNXcHFKc39OwUCYORPLgUJCy0SHAAKCRDNXcHFKc39O1MkD/95Qi1T
aBRhARPnxZgFWMfBIAtKyCC2AFMx28V+AQpAmWR/Stm+qGCAfV4HFTmekATzR4X4
L7E35AJxOHyhmLiEXZGw9jULRGhg2TqIJlDLClh+D2QxRcKcRnRcjNGV1tiBOKCP
M8KUytwMdEb7PLnQRBl2BV183g1LJ9OlLgSgPgk7sJjLLM6qobxJ3o6hpuKTW5X0
pS8qiFjQlv9AOYEllcBBWKzKgUUqKrCaxruIG761fQC4Fwx+FWB+Je48xM6nm8Vh
n4oyuC0+Gu8sglI/d/RI8e+gpMk5obWEAXDn5PFSsKaJnOW38ft0Qvq/3Ukg4AS0
3lXF9LXWxuv6e0gIlpt6HRW7L3pYVyqROVuGcgUWGf9tajjoAqtHHq5a467uj6bp
SfWC0bxUXrr4+x0/yROeq07yw8h9bUi9ygS+kvKYVrgjGQVIY3TvmY9UJD65L733
lb2DvllX+Dzxyt9aV/6F9i2lajOKonmLJmbZ25W6W7wrR+hnmuDNqZmPthjynh9z
3IEYNicFhAlX8lZaGEu50M/MrK85H8L/xBWqXzHFbaCS6jvZOabC8LaEjrR98WrZ
IBzVdoS4JlbwbeN4W3H4zOl7ITNPul1Xb7sbnOi33vn6HxW7vp0ArTIw7ldad456
zEdLbtUUmAEsS7dXIajCau0klhdqGHD9VXoRK8LBlAQTAQoAJwUCWXmkEQIbAwUJ
B4YfgAULCQgHAwUVCgkICwUWAgMBAAIeAQIXgAAhCRDNXcHFKc39OxYhBMs219Lr
suNdm3VQC81dwcUpzf07OOoP/iiS9zOgX6/SvZrjYxHgOsgUuR5mdrQSSNz4haSQ
uTATuR/t7pCPJ8s2IpdyYRKgnE1LKQRm25Km8G0kLktfVWARx8YUgJ+wfzBxQhZ5
WyhM0t3B8qfeZRjyyf8uRV150sXZQtRFxXLkox1kdu3AlBrh/tXYrsodnmaE+Xzd
u4OQeXo9BMV6AqfCeDLTIXB14xsuyor9Am3GPL2BGG6neRrDL5O1GSGvr1kzMyRN
X6eprBX1Bcx12EYTv0yovIkbVWlFHGjh8+5G9tunJFZ8yDtwo7BoO8tfQWGlnwuk
cNF6j3wn+z6CY4UcWwv/WVro8v6ZGjrTgaKviGRApIh7ClHGYDXVO8TMghNGuYzr
ya8yp2ujBCz3M08nlqmby9HSjYZZcOViSIc3+ZnBajm9TpTY1sQtQZznjZOdX/hQ
7Y8Tsqej+7i9HT8u4+EwO2h4EDSstlL8d/hLvRByi9k9+cVz75mtWVcm0JTASs+6
240yIik3+S6k7RchOCseiEtva8oMiT8c/Na+KW46BlCMS54cS/ui8MQj8Jm5CHxU
Q/oJPDg5oYGPeOw+lQTz66x+FPWIlCWe9fG97QiaLmyz6xlH2xZSmhgZaCvi3dLp
SRma0FsYit8tSjtQBfJNYHvbrSaMCwKvK2TlHUj2/3I6NzrLKaiUfTkEFzTtJ+li
92P2zsFNBFl5pBEBEADLdOm3qGHv75gFkfdcuQVCLtczZkD9jTQGdSYdSt6u2gFR
GpslZnReItiVRe3050Rlg4ioIxdn/SiQNpgvb+hCupeyiv+6EHxYMpqZLvIUi47a
f01iGWdQ/c9ehnaplmkRnTJKpo3+1qctugOUwrFGxr59bZvT/D8ajX4Ar9wmqRYT
3IiuKP3uIF2O7VG2DAuuQ5qtzqCVlswBqng5mx+FOQXKGQZPkhcpJxf+TVhrsxNM
pek0ZIBIc53sgXGldW5klXFgaTaM6MmQuPSYIK8BSRMXeUEBNOolm8fjpFh2LTmy
UikHd5YgtRHABcyNAaGUOWRPFaE16VUF0HLGLW1io+QUXohCKL4t//gpo8VBUjO3
43npUcFVnodPxZw+ysReS7IVA5a3PySEcSPUWGXG4aFwdVDHP+Ul+QE9PmvOqRms
u8hNCUBrWqdR4ucn9cgzCa9YvPbtS3yl2x29ozDs8og2EdpGjztCA6QyepIz3HxQ
HDbfxaScOVN5gSsvLR5SDKBXf+YUxQX/T564925l8dnUndWN5erEI4XHkiAC0CPe
UH12Oe2tOJh1ETvwgscMy5SniNUKe80/U4le6AcfObmNlba8T3T5jxxdMvRZ4StT
6tlQDed1hxivTBLsiFf1cXmze8NrQ4VYvUiNlJnRrg3ay5QgYU9FHgmLdoxcRQAR
AQABwsF8BBgBCgAmAhsMFiEEyzbX0uuy412bdVALzV3BxSnN/TsFAmDkTy8FCQst
Eh4ACgkQzV3BxSnN/TsByw//a2+f7tQHVA/RrOCzwen1W0aWf3Fwscbg1kmNk8qz
qtRE677wJt1sktPXEmuhY+wRDa9x07O+3hBYfQDv6sLFx4HDU2d0Lfthgirj6eFu
xQn9OTHIek24qpP6lAtfzvSGMV4EkJWUakqh6BisBPbbniGDzucs/5HkbSP4jvX4
Nh3vV8+8t6LvlSL0zrTat11zAVtwbLlDNWnmv0xrIDfcOdeN/j0LkALFY7UkKxwW
MXaOnpBk4RMRCmlVw9mTH36dxAVRo2t15crVGdBydH85UsNXb2r+FErZyHwbGWEw
WXXx2TCz5F4MS9A0GpatWxZskAo+BrLlAdktzIXQQpjQi1mZ1BfYk6IGJvTa6OSc
pQTjyT08QZHCPww/YnwYFFUwhp7/pMDGGZh9XISaPueiJNPERw7DVEYZysIoxp+W
r1jYzGFxaQfaAtZsQiCj+7F73eAF6kUyY0m2+Enp+hjZl9njDT+hBaZTTN1wetr3
bG2R2CDa+fnqShyYmY+HPAWXkJNaX2K8jvTQw+iljSM4D3G5TOCnXwmqiO3dT+MM
e/QG5g+n9ZM5jbbADyX8d2emXRy/rR7a6GijT479BGeZyY0EWcrVaF4ZrXdLYkLj
dVyaegYABm8PiBUnt9lSDx2WqwwoUemutxAIKmrggT84FAbfX1OMAw9ZTggYyNSR
vmnCwXwEGAEKAA8FAll5pBECGwwFCQeGH4AAIQkQzV3BxSnN/TsWIQTLNtfS67Lj
XZt1UAvNXcHFKc39OxuRD/92yDV+/NhkO/3z1T91y9kdZ1AeGNHPX5jahKZHOxpv
6VsIx32du0drgI2NzlTEWtmy3zft8G9Q+uV00UID3hQ4QQ5FFQme0t1weE2c8r6k
GQvMtxBu3DD2cP3gHqGp0s0PmJaGcq4jsFcWDy7Mfd9GsSHE0HJ9e/VTKr1qiWxu
9GN8Wwvuf/7TZoq4HMg7lVsV503RpnnaYDVqigMoPr2SmkFZez6zE+QeSkJ7ElSS
vd6SOwfyOTXQ696vwM2PxA3iKLYjf/GxEIK+u9wo1+bgtHj0on7lhRSQ6jXFZLA7
NYdX2WmfZpswSqoiqe5u8Q1yU2KohsTq+QBogvK5uKWDFNVtzpKe1RqtQ7/n2PZr
Rz6kOceAsHv31ueHSYCZdcJU7dnXgalofXmJpQKBGDHH24/6VAiPou2s86xzlvkn
pUuB3FCUNd6Mp709ozr5qC0gGZsjbi3fqWOZGuFrZAf3QyHIM+sn9TpyH+KWBNM1
FZt9OwAtHHM2ace+PRjnkix1iDdubvVBP33H2Q26jOjsjgysYSVL70/DLfWVxjXs
5LL8rXCqksJbV7FzhLAlGwAiY1ZAs1zAzHV8gGE+LK6FFWyOgIR1rms741gXxTy7
9SteLE1ewcYGBrKdY7+sj0oWDR81h44bxeebgLG5apS7QUMy/oGGQwJPPZfjFydu
0g==
=bAg3
-----END PGP PUBLIC KEY BLOCK-----
/cc https://github.com/bisq-network/compensation/issues/1237
The release of v1.9.9 was the first public release of @alejandrogarcia83 🚀 . Congrats! It ships a couple of fixes for v1.9.7 to improve the new decentralization of fee distribution.
/cc https://github.com/bisq-network/compensation/issues/1237
No release took place in the last cycle. I've revoked my maintainer bond now based on the agreement to phase out my maintainer role as @alejandrogarcia83 took over the release duties. Thanks for that! I'll still help out with reviewing and merging every now and then until my availability increases again to contribute more.
/cc https://github.com/bisq-network/compensation/issues/1251
Hi!
I was the Bisq 2 repository maintainer for the past two years. The previous maintainer gave me maintainer rights before leaving the project, even though I never locked up a bond. Up until last week it didn't matter because Bisq 2 wasn't released yet and there was no risk involved. I think it's time to hand over my maintainer rights to @alejandrogarcia83 (bonded Bisq 2 Release Manager).
@gabernard Please remove me as a maintainer and give @alejandrogarcia83 (bonded Bisq 2 Release Manager) the needed permissions to manage the Bisq 2 repository.
I'll still contribute as usual and review PRs in the future.
Docs: https://bisq.wiki/Bisq_Maintainer Team: @bisq-network/bisq-maintainers