bisqwit / adlmidi

ADLMIDI is a MIDI player that uses OPL3 emulation.
59 stars 10 forks source link

Turn ADLMIDI into the "ADLCPP" library with keeping the same functionality #7

Open Wohlstand opened 3 years ago

Wohlstand commented 3 years ago

As was discussed at #3, I started to work on a turning ADLMIDI into the library. This is my complete work to split ADLMIDI into the library part, and users part. Most of the code was been moved into own cc files but didn't change. Therefore, a thing is working with the same as before the rework.

An updated build will produce two binaries:

However, I still need to complete the work, and there are items I need to complete:

EDIT August 29, 2020:, I had to complete the full list, and now the thing is ready for merge.

The shortlist of all changes I made in this PR:

Feel free to write any comments, suggestions, tips, and notices here.

Wohlstand commented 3 years ago

On Windows, it properly builds via QMake only, by direct build via mingw32-make it fails strongly even on a pure master branch build.

Wohlstand commented 3 years ago

For a friendly usage of MIDI playing API, I made the AdlSimpleMidiPlay class, defined at adlcpp.h for public, and the simple usgae example through SDL Audio.

Wohlstand commented 3 years ago

It's the shortlist of what I did in it:

Wohlstand commented 3 years ago

The conflict that shown here is because I had to move src/midiplay.cc to utils/midiplay.cc.

Wohlstand commented 3 years ago

Okay, I had to rebase my branch, and it should be ok to merge.

Wohlstand commented 3 years ago

@bisqwit, ping?

bisqwit commented 3 years ago

@bisqwit, ping?

I am alive, just very backlogged and delayed with pretty much everything possible.

Wohlstand commented 3 years ago

No problem, good luck then to resolve that as soon as possible! :wink:

Wohlstand commented 3 years ago

Hello! A bit more than two months has left until the "year anniversary" will happen for this pull request. How are you? Do you have any news?

Wohlstand commented 2 years ago

@bisqwit, ping?

Wohlstand commented 2 years ago

@bisqwit, are you okay?

bisqwit commented 2 years ago

Yes, but I am only one person. Sorry.

Wohlstand commented 2 years ago

I understand, I just wanted to ask how are you

Wohlstand commented 1 year ago

@bisqwit, ping?

Wohlstand commented 1 year ago

@bisqwit, Hello, how are you? Long time not see :)

Wohlstand commented 11 months ago

@bisqwit, ping?

Wohlstand commented 8 months ago

@bisqwit, ping? Are you okay?