search

bistromath / gr-air-modes

Gnuradio Mode-S/ADS-B radio
This project implements a Mode S receiver for the Gnuradio software-defined radio project. It is designed to receive Mode S transmissions from aircraft and decode them to a human-readable format, including ADS-B information messages such as position and a
GNU General Public License v3.0
438 stars 126 forks source link

Fix for crash on Ubuntu 20, GR 3.8 #109

Closed jaredd closed 4 years ago

jaredd commented 4 years ago

The issue this PR addresses was outlined in #108 . Incidentally, I do not have GR 3.8.2 as in the OP but GR 3.8.1.0-1 from the testing repository channel in Debian Buster. These minor changes fix a recurring SyntaxWarning with screen output as well as the crash due to RuntimeError.

jaredd commented 4 years ago

I realize I'm muddying up this PR but I also found that the sbs1 message was not converted to bytes prior to sending which crashed the modes_rx app when a client connected to the sbs1 server. Quick fix seems to work. This seems just another python2 to python3 issue that hadn't been ported yet.

bistromath commented 4 years ago

Thanks Jared. I don't have an SBS1 here to test with, so that's especially appreciated.

jaredd commented 4 years ago

Thanks Jared. I don't have an SBS1 here to test with, so that's especially appreciated.

To be clear, I didn't test the validity of the SBS1 message strings, I only corrected the TypeError (if I recall the exception type) that resulted when I tried to connect to the SBS1 server port. I simply ran nc and output the message strings, which seemed reasonable after the fix.