search

bit-bots / YOEO

YouOnlyEncodeOnce - A CNN for Embedded Object Detection and Semantic Segmentation
GNU General Public License v3.0
22 stars 4 forks source link

feature: load detection class names from yaml file #24

Closed phinik closed 2 years ago

phinik commented 2 years ago

Proposed changes

added the possibility to load (detection) class names from a yaml file (key 'detection')

Necessary checks

Flova commented 2 years ago

One could also add the segmentation names to the printout in the evaluation: This would be a bit more effort, but it would be nice now that they are available.

jaagut commented 2 years ago

We probably also want to adapt the path in https://github.com/bit-bots/YOEO/blob/bb22da191a6d3cec592df07d58f6fa7475c4b025/config/261.data#L4 to the new format.

Before we do that, I would suggest moving the TORSO.names / yoeo_name.yaml file from the data dir to the config dir? Then, we would need to adapt the path also in the detect.py...

What is your opinion?

phinik commented 2 years ago

We probably also want to adapt the path in

https://github.com/bit-bots/YOEO/blob/bb22da191a6d3cec592df07d58f6fa7475c4b025/config/261.data#L4

to the new format. Before we do that, I would suggest moving the TORSO.names / yoeo_name.yaml file from the data dir to the config dir? Then, we would need to adapt the path also in the detect.py...

What is your opinion?

I leave it up to you and Flova to decide on this.

Flova commented 2 years ago

We probably also want to adapt the path in

https://github.com/bit-bots/YOEO/blob/bb22da191a6d3cec592df07d58f6fa7475c4b025/config/261.data#L4 to the new format.

But the 261.names is not in the repo and I wonder why the 261.data file is in the config folder xD The dataset was just used for local tests.

Before we do that, I would suggest moving the TORSO.names / yoeo_name.yaml file from the data dir to the config dir? Then, we would need to adapt the path also in the detect.py...

I also wonder a bit if we really want to do this, as the .data, as well as the .names file, are normally part of the dataset. But we should adapt the custom.data example file to the yaml version never the less.

We also need to adapt the README.md section that describes the expected data structure. Especially this section: https://github.com/bit-bots/YOEO/tree/main#classes A sample yaml for TORSO could be added.

jaagut commented 2 years ago

We also need to adapt the README.md section that describes the expected data structure. Especially this section: https://github.com/bit-bots/YOEO/tree/main#classes A sample yaml for TORSO could be added.

This should be another PR