search

bit-bots / humanoid_league_misc

MIT License
0 stars 2 forks source link

Change type of obstacle message callback #126

Closed timonegk closed 1 year ago

timonegk commented 1 year ago

Proposed changes

Related to #125. This change is not a solution but changes the subscription to avoid the message type conflict.

timonegk commented 1 year ago

Regarding future work, I talked to @Flova and he said that the vision already uses the robot messages and never publishes obstacle messages, so we only need to change it here and can drop the obstacles.

Flova commented 1 year ago

I think the obstacle and robot messages are both interesting and ideally we would communicate both. But currently we only detect robots so this is definitely prioritized.

jaagut commented 1 year ago

What's the status of this PR? Do we want/need to continue with it?

Flova commented 1 year ago

I think it has been superseded by #127