bit-bots / humanoid_league_misc

MIT License
0 stars 2 forks source link

Feature: refactor and test team comm #127

Closed texhnolyze closed 1 year ago

texhnolyze commented 1 year ago

Proposed changes

Major refactoring of team communication including the following:

Related issues

Necessary checks

texhnolyze commented 1 year ago

I'm still doing some testing and there are also still @TODOs in the code, but as this is a big PR I think it makes sense, that you already have a look over the general stuff. For most of the TODOs I could also use your feedback.

Flova commented 1 year ago

But isn't the target configurable and thus dynamic? Or what do you mean

But semantically it should still be the map frame. Maybe prefixed by a robot name or something like that. tf_transform sounds very generic and not like a function that only transforms into the map frame.