search

bit-bots / humanoid_league_misc

MIT License
0 stars 2 forks source link

Use mimic for speaker #130

Closed Flova closed 1 year ago

Flova commented 1 year ago

Proposed changes

Limitations

Related issues

129

https://github.com/bit-bots/bitbots_motion/pull/388

Flova commented 1 year ago

New dependency on mycroft-mimic3-tts via pip.

Flova commented 1 year ago

Also tested on robot. Sounds the best at ca. 90% volume.

Flova commented 1 year ago

Maybe we should open an Ansible issue for that? @timonegk

Flova commented 1 year ago

We also need to add the new dependency to the meta requirements before this pr is merged.

Flova commented 1 year ago

I opened an issue in the ansible git

jaagut commented 1 year ago

Sounds good on the robot. Please change the volume in set_volume.sh and the motion launch file. 100% sounds really bad, I prefer 70-80%.

We have this issue regarding that: bit-bots/bitbots_misc/issues/90

Could we still do it via dynamic reconfigure? Is it necessary?

Flova commented 1 year ago

This is not easily possible anymore with the current architecture :(

We use aplay to play the sound and it only works with the system volume. We could adjust the system volume via a ros parameter, but this seems to be not so clean imo.

jaagut commented 1 year ago

Yeah, I am also fine with @timonegk suggestion. If we agree on that, we could close the issue I mentioned above.

jaagut commented 1 year ago

Sounds good on the robot. Please change the volume in set_volume.sh and the motion launch file. 100% sounds really bad, I prefer 70-80%.

I would have only changed the volume to 75% in the motion launch file. I believe the default of the script if no value is given, should still be 100%.

jaagut commented 1 year ago

I would have only changed the volume to 75% in the motion launch file. I believe the default of the script if no value is given, should still be 100%.

Done in bit-bots/bitbots_misc/pull/208