bit-bots / humanoid_league_misc

MIT License
0 stars 2 forks source link

Team comm: Handle messages without extension #93

Closed jaagut closed 1 year ago

jaagut commented 3 years ago

Is your feature request related to a problem? Please describe.

Currently, the team comm only handles our custom protobuf message robocup_extension_pb2.Message(). We should also be able to handle the default robocup_pb2.Message(). This is especially relevant for DropIn games.

Describe the solution you'd like

Describe alternatives you've considered

texhnolyze commented 1 year ago

As far as I've read up on Protobuf our extended Msgs should be interchangeable with the base messages, as they are only an extension and will lead to the extra fields just not being parsed, when they are not available. We just need to make sure, that all our extra fields are always optional (which they always are anyway in proto3, exactly because this lead to backwards compatibility issues in proto2).